Skip to content

Conversation

@MahdiBaghbani
Copy link
Member

Fixed: #5414

Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again well spotted, I wonder if the fact that we only use in production the SQL driver made this bug hidden when running the demos

@glpatcern glpatcern merged commit 3858ef8 into cs3org:master Dec 1, 2025
14 checks passed
@MahdiBaghbani
Copy link
Member Author

MahdiBaghbani commented Dec 1, 2025

@glpatcern The previous one was related to json driver but this one is also valid when using sql as well.

Only 1 out of 4 possible ways to do invite and share would reveal this problem :-) so that's how it evaded us for 3 years

MahdiBaghbani added a commit to MahdiBaghbani/reva-opencloud that referenced this pull request Dec 1, 2025
* fix: wrong user type in AcceptInvite handler

* add: changelog
glpatcern added a commit that referenced this pull request Dec 18, 2025
* add: LocalFS virtual namespace support

Add optional VirtualHomeTemplate config to expose localhome paths in a
virtual namespace (e.g., /home/<user>/) while storing files in the
existing flat layout. When empty, preserves original behavior for EOS
and other deployments.

Fixes PathToSpaceID() encoding issues where localhome returned paths
like '/file.txt' instead of '/home/<user>/file.txt', causing each file
to be treated as its own space.

* fix: Handle parent paths in virtual namespace mapping

* fix: Pass VirtualHomeTemplate to localfs driver

* fix: localhome virtual namespace and mount_path interaction

* fix(localfs): handle gateway-stripped paths in virtual namespace

fix(localfs): handle gateway-stripped paths in virtual namespace

* fix(localfs): add virtual home prefix in unwrap for space-based routing

* refactor(localfs): use switch and predicates in localfs wrap()

Also handle the webdav storage accessing pattern

* fix(localfs): opaque id double path problem

moved the logic from unwrap() to normalize, to handle
different requirements for Path and OpaqueId construction

* add: debug logger, will remove later

* fix: missing log

* debug: i need stack tracing, the spaceId is getting lost somewhere

* debug: first propfind has sapceid, second doesn't have, let's see why

* debug: deploy overwhelming debug firepower (PRINTs everywhere)

Every single step will be logged

* debug: unleash a flood of debug prints upon the propfind

* fix: nil pointer on multistatus propfind debug

* fix: nil pointer on multistatus propfind debug, take 2

* remove: debugs

* fix(ocminvite): correct inverted expiry check in JSON repository (#5418)

* Bugfix: Set correct user type when accepting OCM invites (#5415)

* fix: wrong user type in AcceptInvite handler

* add: changelog

* Delete former changelog

* Delete former changelog

* remove: redundant debug logs

---------

Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong user type assignment for OCM invite

2 participants