NotifyUploads on dropzones in libregraph #5339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
92f52c9 to
7b056a4
Compare
7b056a4 to
91569e1
Compare
Contributor
Author
|
@glpatcern could you specifically take a look at what you think of removing the |
glpatcern
reviewed
Oct 2, 2025
Member
glpatcern
left a comment
There was a problem hiding this comment.
I think it makes perfect sense to remove the CreateContainer, especially as we flatten folders when people upload them (otherwise it would defeat the purpose of not knowing what is in the storage). You can remove it "for good" by dropping the comments IMO.
91569e1 to
eee3f39
Compare
eee3f39 to
c088aa8
Compare
glpatcern
approved these changes
Oct 3, 2025
jessegeens
added a commit
that referenced
this pull request
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.