Support deserialization of YAML anchors of value types#16186
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Oct 18, 2025
Merged
Conversation
ysbaddaden
approved these changes
Oct 3, 2025
Contributor
|
Would be a nice company to a #15941 given the slew of serialization-related changes in 1.18.0... ^^ |
straight-shoota
approved these changes
Oct 6, 2025
Member
|
We're past the merge window for 1.18, so this has to wait for 1.19. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #13830. All objects are now boxed so that they can be stored into the parse context uniformly.
This does not affect how the GC sees
YAML::ParseContext#@anchors; since the hash's key type isString,Hash::Entry(String, T)is always non-atomic, thus the switch fromUInt64toVoid*makes no differences. (In factVoid*is probably more correct here.)YAML.parsealready handles anchors regardless of their types, since they are allYAML::Anys;YAML::Nodes.parsereturns a document and never resolves aliases. These methods are not affected in this patch.