Resolve YAML aliases in YAML::Any#15941
Merged
straight-shoota merged 3 commits intocrystal-lang:masterfrom Jul 19, 2025
Merged
Conversation
straight-shoota
approved these changes
Jul 16, 2025
ysbaddaden
approved these changes
Jul 17, 2025
YAML::AnyYAML::Any
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15937 where
YAML::Anywill not correctly merge aliases into maps.This file is parsed correctly:
With this patch the result is:
With 1.16.3 the result is:
(note the
<<submessage inmodifiedthat should have been splatted into the outer map).I'm not sure if this is the best way to fix the issue, I don't really have a good understanding of how all the YAML parsing fits together, so I could totally be putting an inappropriate bandaid on this.