appindicator support#18
Conversation
overheadhunter
left a comment
There was a problem hiding this comment.
Thanks, this looks really promising! I still have some concerns, but we'll work this out! 🙂
| requires org.freedesktop.dbus; | ||
| requires org.purejava.appindicator; | ||
| requires org.purejava.kwallet; | ||
| requires secret.service; |
There was a problem hiding this comment.
I still hope for an updated version of this lib as well, as it can easily become fully modular too (needs issues 37 and 38 to be worked on).
I hope this is now the only lib using org.freedesktop.* classes, otherwise we might run into a problem.
There was a problem hiding this comment.
I hope this is now the only lib using
org.freedesktop.*classes, otherwise we might run into a problem.
I hope the same. Fingers crossed. 🤞🏻
| private String getAbsolutePath(String iconName) { | ||
| var res = getClass().getClassLoader().getResource(iconName); | ||
| if (null == res) { | ||
| throw new IllegalArgumentException("Icon '" + iconName + "' cannot be found in resource folder"); | ||
| } | ||
| File file = null; | ||
| try { | ||
| file = Paths.get(res.toURI()).toFile(); | ||
| } catch (URISyntaxException e) { | ||
| throw new IllegalArgumentException("Icon '" + iconName + "' cannot be converted to file", e); | ||
| } | ||
| return file.getAbsolutePath(); | ||
| } |
There was a problem hiding this comment.
Does this really work? After all the icon is bundled within a jar. Is it really a "file" that can be read from within GTK?
There was a problem hiding this comment.
Does this really work? After all the icon is bundled within a jar.
It worked in the IDE. The final application is probably different than the compiled code in the IDE. Needs more testing.
Is it really a "file" that can be read from within GTK?
No, the method takes the "icon_name" which is either the (short-) name of an icon installed on the system or its absolute path (what I am using here). The solution might be to use app_indicator_set_icon_theme_path. libappindicator does not offer to much opportunities, though.
There was a problem hiding this comment.
It worked in the IDE. The final application is probably different than the compiled code in the IDE. Needs more testing.
That's what I thought. In the IDE it is a "normal" file, it is not yet packed into a .jar archive. So either we need to unpack it from the jar to a temporary directory or bundle the icon with the installer in a way such that the icon will be installed as a regular file that we know the path of.
There was a problem hiding this comment.
Do you know how to resolve an icon "by name"? How do you register icon files? Will GTK use this freedesktop specification? In that case we might just use the icon named org.cryptomator.Cryptomator. The desktop menu makes use of this icon name, too.
Our .deb file (ppa), the Flatpak package as well as our AppImage adhere to this standard.
@SailReal How about our AUR release? The AUR does the same. 🎉
There was a problem hiding this comment.
The getAbsolutePath(...) stuff was removed. As not needed any more.
We need to add a "org.cryptomator.Cryptomator-unlocked" SVG to our releases, so that it gets installed as an icon on Linux. The file is already in the repo as src/main/resources/tray_icon_unlocked.svg and can be removed afterwards, together with tray_icon.svg (which is already available as "org.cryptomator.Cryptomator").
There was a problem hiding this comment.
Done as well. For ppa, appimage and flatpak.
There was a problem hiding this comment.
Just for the record: Did you confirm, this works? Or did you find any source confirming that libappindicator and libayatana refer to this freedesktop spec with this "icon name"?
There was a problem hiding this comment.
In the first link to the debian wiki you provided the lib usees the freedesktop icon spec and libayatana is the same and that's what I did during testing all the time. So: yes.
Please note, I didn't build the ppa, nor the appimage or the flatpak app. The flatpak app requires the icon in the downloaded package that wasn't included at that time.
|
Oh, the GitHub Actions need to be updated to JDK 20 as well. 😊 |
How good you are so thorough. 😃 |
Discussion: #18
Discussion: #18
|
The |
Discussion: #18
|
All recommendations are implemented now for all appindicator PRs. |
|
@purejava Thank you for this amazing contribution! |
|
@infeo You are very welcome! 🤗 |
I changed
integrations-linuxfrom Java 19 to 20 already, but can revert that, if it's not liked.