Add Minimize Button#1472
Conversation
…ty `cryptomator.showTrayIcon`
infeo
left a comment
There was a problem hiding this comment.
I guess this PR was kinda overdue^^
It is good, but i have a fundamental question:
Why is the general tray icon support (i don't mean the actual support, but the intended one) controlled by a system property?
For an installed application, these can be seen as not changeable (e.g. inside an appimage), hence this is mainly for debugging, or not?
Additionally, our settings object depends with change also on the environment. As a consequence there is no "default" settings object anymore, but an environment dependent one. This can be beneficial, but also a pitfall. But in the end this is only done once for each user account on a system,.
The bottom line: I can't see, why default value for tray icon is not sufficient.
Because on Linux we should disable tray support by default (due to all the linked issues) and have the users explicitly enable it again (if they know the DE supports it or they want a buggy tray icon anyway). While on macOS and Windows we want it to be the other way round. The system property allows such differentiation per installer. |
|
For Documentation: The system property to control tray menu enabled or not is |
Basically this adds two more options to the general Preferences:
It is worth mentioning, that the minimize button is still obligatory when no tray icon exists, in which case the corresponding checkbox will be invisible.
This also rewires interactions between the Dagger components Launcher, TrayMenu and FxApplication.