abci: Add relaxed local client synchronization models (backport #1141)#2
Merged
yihuang merged 2 commits intocrypto-org-chain:v0.38.xfrom Nov 1, 2024
Merged
Conversation
* proxy: Remove "unsynchronized" local client creator Signed-off-by: Thane Thomson <connect@thanethomson.com> * proxy: Expand client creator interface Expand the `ClientCreator` interface to allow the caller to explicitly specify the "connection" whose client they are creating. This potentially gives greater control over the concurrency model employed in each type of connection. Signed-off-by: Thane Thomson <connect@thanethomson.com> * abci/client: Clarify NewLocalClient description Signed-off-by: Thane Thomson <connect@thanethomson.com> * proxy: Add connection-synchronized local client creator Analogous to the old "unsynchronized" local client creator. Signed-off-by: Thane Thomson <connect@thanethomson.com> * abci/client: Add unsynchronized local client Signed-off-by: Thane Thomson <connect@thanethomson.com> * proxy: Add consensus-synchronized local client creator Signed-off-by: Thane Thomson <connect@thanethomson.com> * proxy: Fix mock configuration in test Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add changelog entries Signed-off-by: Thane Thomson <connect@thanethomson.com> * Remove changelog entry - no longer necessary Signed-off-by: Thane Thomson <connect@thanethomson.com> * proxy: Add unsynchronized local client creator Signed-off-by: Thane Thomson <connect@thanethomson.com> * changelog: Add entry for unsync local client creator Signed-off-by: Thane Thomson <connect@thanethomson.com> * Update 1141-abci-unsync-proxy.md Co-authored-by: Adi Seredinschi <adizere@gmail.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Adi Seredinschi <adizere@gmail.com>
Author
|
sdk 0.50 only works with |
mmsqe
approved these changes
Nov 1, 2024
JayT106
pushed a commit
that referenced
this pull request
Jan 23, 2026
due to sec vuln Vulnerability #1: GO-2025-3420 Sensitive headers incorrectly sent after cross-domain redirect in net/http More info: https://pkg.go.dev/vuln/GO-2025-3420 Standard library Found in: net/http@go1.23.1 Fixed in: net/http@go1.23.5 Example traces found: Error: #1: rpc/jsonrpc/client/http_json_client.go:231:34: client.Client.Call calls http.Client.Do Error: #2: libs/cli/setup.go:89:26: cli.Executor.Execute calls cobra.Command.Execute, which eventually calls http.Client.Get Error: #3: cmd/cometbft/commands/debug/util.go:70:23: debug.dumpProfile calls http.Get Vulnerability #2: GO-2025-3373 Usage of IPv6 zone IDs can bypass URI name constraints in crypto/x509 More info: https://pkg.go.dev/vuln/GO-2025-3373 Standard library Found in: crypto/x509@go1.23.1 Fixed in: crypto/x509@go1.23.5 Example traces found: Error: #1: abci/tutorials/abci-v2-forum-app/model/db.go:143:20: model.DB.Close calls badger.DB.Close, which eventually calls x509.CertPool.AppendCertsFromPEM Error: #2: internal/autofile/group.go:468:30: autofile.GroupReader.Read calls bufio.Reader.Read, which eventually calls x509.Certificate.Verify Error: #3: rpc/jsonrpc/client/ws_client.go:290:29: client.WSClient.dial calls websocket.Dialer.Dial, which eventually calls x509.Certificate.VerifyHostname Error: #4: light/errors.go:483:84: light.errBadWitness.Error calls x509.HostnameError.Error Error: #5: rpc/jsonrpc/server/http_server.go:166:19: server.ServeTLSWithShutdown calls http.Server.ServeTLS, which eventually calls x509.ParseCertificate Error: #6: rpc/jsonrpc/server/http_server.go:166:19: server.ServeTLSWithShutdown calls http.Server.ServeTLS, which eventually calls x509.ParseECPrivateKey Error: #7: rpc/jsonrpc/server/http_server.go:166:19: server.ServeTLSWithShutdown calls http.Server.ServeTLS, which eventually calls x509.ParsePKCS1PrivateKey Error: #8: rpc/jsonrpc/server/http_server.go:166:19: server.ServeTLSWithShutdown calls http.Server.ServeTLS, which eventually calls x509.ParsePKCS8PrivateKey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proxy: Remove "unsynchronized" local client creator
proxy: Expand client creator interface
Expand the
ClientCreatorinterface to allow the caller to explicitly specify the "connection" whose client they are creating. This potentially gives greater control over the concurrency model employed in each type of connection.abci/client: Clarify NewLocalClient description
proxy: Add connection-synchronized local client creator
Analogous to the old "unsynchronized" local client creator.
abci/client: Add unsynchronized local client
proxy: Add consensus-synchronized local client creator
proxy: Fix mock configuration in test
Add changelog entries
Remove changelog entry - no longer necessary
proxy: Add unsynchronized local client creator
changelog: Add entry for unsync local client creator
Update 1141-abci-unsync-proxy.md
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments