This repository was archived by the owner on Jul 27, 2022. It is now read-only.
Problem: (CRO-619) Missing script to do final checkings before push#644
Merged
bors[bot] merged 1 commit intocrypto-com:masterfrom Nov 29, 2019
calvinlauyh:feature/cro-619-before-push-script
Merged
Problem: (CRO-619) Missing script to do final checkings before push#644bors[bot] merged 1 commit intocrypto-com:masterfrom calvinlauyh:feature/cro-619-before-push-script
bors[bot] merged 1 commit intocrypto-com:masterfrom
calvinlauyh:feature/cro-619-before-push-script
Conversation
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
=======================================
Coverage 69.32% 69.32%
=======================================
Files 127 127
Lines 15287 15287
=======================================
Hits 10597 10597
Misses 4690 4690
|
Contributor
Merge conflict (retrying...) |
bors bot
added a commit
that referenced
this pull request
Nov 29, 2019
641: Bump jsonrpc-derive from 14.0.3 to 14.0.5 r=tomtau a=dependabot-preview[bot] [//]: # (dependabot-start)⚠️ **Dependabot is rebasing this PR**⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [jsonrpc-derive](https://github.com/paritytech/jsonrpc) from 14.0.3 to 14.0.5. <details> <summary>Commits</summary> - [`23e6097`](paritytech/jsonrpc@23e6097) 14.0.5 bump ([#524](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/524)) - [`d2e0bb7`](paritytech/jsonrpc@d2e0bb7) Fix basic example from on the readme file ([#523](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/523)) - [`b6e7521`](paritytech/jsonrpc@b6e7521) Bump version. ([#522](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/522)) - [`d661b0c`](paritytech/jsonrpc@d661b0c) Avoid using buffer_unordered ([#518](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/518)) - [`591e916`](paritytech/jsonrpc@591e916) workaround serde deserializing incorrectly when arbitrary_precision enabled (... - [`1d351d3`](paritytech/jsonrpc@1d351d3) upgrade parity-tokio-ipc ([#519](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/519)) - [`8912104`](paritytech/jsonrpc@8912104) Update websocket requirement from 0.23 to 0.24 ([#516](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/516)) - [`2d38e64`](paritytech/jsonrpc@2d38e64) Update env_logger requirement from 0.6 to 0.7 ([#493](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/493)) - See full diff in [compare view](paritytech/jsonrpc@v14.0.3...jsonrpc-derive-v14.0.5) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=jsonrpc-derive&package-manager=cargo&previous-version=14.0.3&new-version=14.0.5) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> 644: Problem: (CRO-619) Missing script to do final checkings before push r=tomtau a=calvinlauco Solution: Add script to do final checkings including build, test, clippy and audit --- - By default, it runs at quiet mode with a minimum logs output. - Toggle verbose mode by `./before_push.sh --verbose` Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Calvin Lau <calvinlauco@gmail.com>
Contributor
Canceled (will resume) |
Contributor
|
bors retry |
Contributor
|
Already running a review |
bors bot
added a commit
that referenced
this pull request
Nov 29, 2019
644: Problem: (CRO-619) Missing script to do final checkings before push r=tomtau a=calvinlauco Solution: Add script to do final checkings including build, test, clippy and audit --- - By default, it runs at quiet mode with a minimum logs output. - Toggle verbose mode by `./before_push.sh --verbose` Co-authored-by: Calvin Lau <calvinlauco@gmail.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: Add script to do final checkings including build, test, clippy and audit
./before_push.sh --verbose