Problem: integration test doesn't use tx-query (CRO-618) by tomtau · Pull Request #637 · crypto-com/thaler

tomtau · 2019-11-28T08:07:07Z

Solution:

changed chain-abci, client-cli and client-rpc default compilation not to use the complete mock
added decryption in tx-validation by default
extended client-rpc with mock feature for transaction obfuscation
added dockerfile etc. for tx-query
extended integration test setup + drone pipeline

NOTE: transaction confidentiality is still WIP -- currently data is sealed with a static key known at compile time
(rather than some enclave-only random secret that's periodically re-generated by validators' bootstrapping enclaves),
so it's still a "mock", but better in the sense that client workflows are more realistic / closer to the complete implementation
(decryption queries are over attested TLS to the tx-query enclave rather than plain abci query)

tomtau · 2019-11-28T08:07:16Z

bors try

bors · 2019-11-28T08:22:38Z

try

Build failed

continuous-integration/drone/push

tomtau · 2019-11-28T08:31:39Z

bors retry

bors · 2019-11-28T08:52:02Z

try

Build failed

continuous-integration/drone/push

codecov · 2019-11-28T09:05:54Z

Codecov Report

Merging #637 into master will increase coverage by 0.4%.
The diff coverage is 19.46%.

@@            Coverage Diff            @@
##           master     #637     +/-   ##
=========================================
+ Coverage   70.17%   70.57%   +0.4%     
=========================================
  Files         133      133             
  Lines       16384    16369     -15     
=========================================
+ Hits        11497    11553     +56     
+ Misses       4887     4816     -71

Impacted Files	Coverage Δ
client-cli/src/command.rs	`0% <ø> (ø)`	⬆️
client-rpc/src/server.rs	`8.92% <0%> (-1.28%)`	⬇️
chain-abci/src/enclave_bridge/mock.rs	`87.5% <0%> (+36.5%)`	⬆️
client-core/src/cipher/default.rs	`0% <0%> (ø)`	⬆️
client-common/src/block_header.rs	`0% <0%> (ø)`	⬆️
...lient-core/src/synchronizer/manual_synchronizer.rs	`44.59% <100%> (+0.38%)`	⬆️
client-core/src/handler/default_block_handler.rs	`86.06% <100%> (ø)`	⬆️
client-common/src/tendermint/types.rs	`18% <16.66%> (-0.75%)`	⬇️
...work/src/network_ops/default_network_ops_client.rs	`79.2% <93.33%> (+0.76%)`	⬆️
... and 4 more

tomtau · 2019-11-28T09:19:00Z

bors retry

bors · 2019-11-28T09:41:10Z

try

Build failed

continuous-integration/drone/push

integration-tests/docker-compose.yml

tomtau · 2019-11-28T10:05:39Z

bors retry

bors · 2019-11-28T10:20:27Z

try

Build failed

continuous-integration/drone/push

tomtau · 2019-11-29T04:21:41Z

bors retry

bors · 2019-11-29T04:47:07Z

try

Build failed

continuous-integration/drone/push

tomtau · 2019-11-29T07:34:40Z

bors retry

bors · 2019-11-29T07:58:04Z

try

Build failed

continuous-integration/drone/push

tomtau · 2019-12-02T03:20:44Z

bors retry

bors · 2019-12-02T03:20:47Z

try

Merge conflict

tomtau · 2019-12-02T03:26:45Z

bors retry

tomtau · 2019-12-02T09:19:40Z

bors retry

bors · 2019-12-02T09:40:07Z

try

Build failed

continuous-integration/drone/push

tomtau · 2019-12-02T09:49:16Z

bors retry

bors · 2019-12-02T10:08:18Z

try

Build failed

continuous-integration/drone/push

tomtau · 2019-12-03T03:21:07Z

bors try

bors · 2019-12-03T03:49:00Z

try

Build failed

continuous-integration/drone/push

tomtau · 2019-12-06T06:24:39Z

bors try

bors · 2019-12-06T06:52:31Z

try

Build failed

continuous-integration/drone/push

tomtau · 2019-12-06T07:06:09Z

bors retry

bors · 2019-12-06T07:31:34Z

try

Build failed

continuous-integration/drone/push

Solution: - changed chain-abci, client-cli and client-rpc default compilation not to use the complete mock - added decryption in tx-validation by default - extended client-rpc with mock feature for transaction obfuscation - added dockerfile etc. for tx-query - extended integration test setup + drone pipeline fixed client tx checking and generation: - only send txids of transactions that are relevant to enclaves - don't generate withdraw transaction if staked state isn't unbonded NOTE: transaction confidentiality is still WIP -- currently data is sealed with a static key known at compile time (rather than some enclave-only random secret that's periodically re-generated by validators' bootstrapping enclaves), so it's still a "mock", but better in the sense that client workflows are more realistic / closer to the complete implementation (decryption queries are over attested TLS to the tx-query enclave rather than plain abci query)

tomtau · 2019-12-06T07:38:58Z

bors r+

637: Problem: integration test doesn't use tx-query (CRO-618) r=tomtau a=tomtau Solution: - changed chain-abci, client-cli and client-rpc default compilation not to use the complete mock - added decryption in tx-validation by default - extended client-rpc with mock feature for transaction obfuscation - added dockerfile etc. for tx-query - extended integration test setup + drone pipeline NOTE: transaction confidentiality is still WIP -- currently data is sealed with a static key known at compile time (rather than some enclave-only random secret that's periodically re-generated by validators' bootstrapping enclaves), so it's still a "mock", but better in the sense that client workflows are more realistic / closer to the complete implementation (decryption queries are over attested TLS to the tx-query enclave rather than plain abci query) Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>

tomtau · 2019-12-06T08:44:58Z

oops -- integration test is still executed on Travis: https://travis-ci.org/crypto-com/chain/jobs/621480585?utm_medium=notification&utm_source=github_status

so this will require some work -- some flag for travis and compiling with --features mock-enc-dec mock-validation + a different docker-compose file... @calvinaco @calvinlauco any ideas?

bors · 2019-12-06T08:45:05Z

Build succeeded

tomtau · 2019-12-06T08:45:34Z

or disable integration test on Travis? it seems to ignore it

tomtau requested review from calvinaco, devashishdxt, leejw51crypto, lezzokafka, linfeng-crypto and yihuang November 28, 2019 08:07

bors bot added a commit that referenced this pull request Nov 28, 2019

Try #637:

fa2a423

bors bot added a commit that referenced this pull request Nov 28, 2019

Try #637:

d0feefe

calvinaco approved these changes Nov 28, 2019

View reviewed changes

bors bot added a commit that referenced this pull request Nov 28, 2019

Try #637:

430f054

calvinaco suggested changes Nov 28, 2019

View reviewed changes

integration-tests/docker-compose.yml Outdated Show resolved Hide resolved

integration-tests/docker-compose.yml Outdated Show resolved Hide resolved

bors bot added a commit that referenced this pull request Nov 28, 2019

Try #637:

e6c04b2

bors bot added a commit that referenced this pull request Nov 29, 2019

Try #637:

9e84acc

bors bot added a commit that referenced this pull request Nov 29, 2019

Try #637:

24a9d80

bors bot added a commit that referenced this pull request Dec 2, 2019

Try #637:

cd96847

bors bot added a commit that referenced this pull request Dec 2, 2019

Try #637:

570ded3

bors bot added a commit that referenced this pull request Dec 3, 2019

Try #637:

717c308

leejw51crypto approved these changes Dec 3, 2019

View reviewed changes

leejw51crypto approved these changes Dec 5, 2019

View reviewed changes

tomtau mentioned this pull request Dec 5, 2019

Problem (CRO-594): block results and "fast sync" are not verified in client #651

Merged

tomtau force-pushed the fix/tx-query-integration branch from 4cb940e to 8e76331 Compare December 6, 2019 06:24

tomtau requested a review from calvinaco December 6, 2019 06:24

bors bot added a commit that referenced this pull request Dec 6, 2019

Try #637:

551ecd7

bors bot added a commit that referenced this pull request Dec 6, 2019

Try #637:

dc23617

yihuang approved these changes Dec 6, 2019

View reviewed changes

tomtau force-pushed the fix/tx-query-integration branch from 1019649 to 2952ac4 Compare December 6, 2019 07:38

bors bot merged commit 2952ac4 into crypto-com:master Dec 6, 2019

tomtau mentioned this pull request Dec 9, 2019

Problem: travis CI integration test pipeline is broken #660

Merged

Conversation

tomtau commented Nov 28, 2019

Uh oh!

tomtau commented Nov 28, 2019

Uh oh!

bors bot commented Nov 28, 2019

try

Build failed

Uh oh!

tomtau commented Nov 28, 2019

Uh oh!

bors bot commented Nov 28, 2019

try

Build failed

Uh oh!

codecov bot commented Nov 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tomtau commented Nov 28, 2019

Uh oh!

bors bot commented Nov 28, 2019

try

Build failed

Uh oh!

Uh oh!

Uh oh!

tomtau commented Nov 28, 2019

Uh oh!

bors bot commented Nov 28, 2019

try

Build failed

Uh oh!

tomtau commented Nov 29, 2019

Uh oh!

bors bot commented Nov 29, 2019

try

Build failed

Uh oh!

tomtau commented Nov 29, 2019

Uh oh!

bors bot commented Nov 29, 2019

try

Build failed

Uh oh!

tomtau commented Dec 2, 2019

Uh oh!

bors bot commented Dec 2, 2019

try

Merge conflict

Uh oh!

tomtau commented Dec 2, 2019

Uh oh!

tomtau commented Dec 2, 2019

Uh oh!

bors bot commented Dec 2, 2019

try

Build failed

Uh oh!

tomtau commented Dec 2, 2019

Uh oh!

bors bot commented Dec 2, 2019

try

Build failed

Uh oh!

tomtau commented Dec 3, 2019

Uh oh!

bors bot commented Dec 3, 2019

try

Build failed

Uh oh!

tomtau commented Dec 6, 2019

Uh oh!

bors bot commented Dec 6, 2019

try

Build failed

Uh oh!

tomtau commented Dec 6, 2019

Uh oh!

bors bot commented Dec 6, 2019

codecov bot commented Nov 28, 2019 •

edited

Loading