This repository was archived by the owner on Jul 27, 2022. It is now read-only.
Problem: (CRO-603) Bech32 address always encoded with initialized network#613
Merged
bors[bot] merged 1 commit intocrypto-com:masterfrom Nov 25, 2019
calvinlauyh:feature/cro-603-to-cro-network-arg
Merged
Problem: (CRO-603) Bech32 address always encoded with initialized network#613bors[bot] merged 1 commit intocrypto-com:masterfrom calvinlauyh:feature/cro-603-to-cro-network-arg
bors[bot] merged 1 commit intocrypto-com:masterfrom
calvinlauyh:feature/cro-603-to-cro-network-arg
Conversation
…work Solution: Add network argument to to_cro()
Codecov Report
@@ Coverage Diff @@
## master #613 +/- ##
==========================================
+ Coverage 68.89% 68.91% +0.01%
==========================================
Files 126 126
Lines 14970 14976 +6
==========================================
+ Hits 10314 10320 +6
Misses 4656 4656
|
Contributor
Merge conflict (retrying...) |
bors bot
added a commit
that referenced
this pull request
Nov 25, 2019
613: Problem: (CRO-603) Bech32 address always encoded with initialized network r=tomtau a=calvinlauco Solution: Add network argument to to_cro() --- `to_cro()` always encoded with the initialized network, making it mpossible to encode to arbitrary network 615: Bump serde_json from 1.0.41 to 1.0.42 r=tomtau a=dependabot-preview[bot] Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.41 to 1.0.42. <details> <summary>Release notes</summary> *Sourced from [serde_json's releases](https://github.com/serde-rs/json/releases).* > ## v1.0.42 > - Add `impl From<()> for Value` which produces Value::Null ([#585](https://github-redirect.dependabot.com/serde-rs/json/issues/585), thanks [@​Nilix007](https://github.com/Nilix007)) </details> <details> <summary>Commits</summary> - [`f0471e6`](serde-rs/json@f0471e6) Release 1.0.42 - [`bf8cc66`](serde-rs/json@bf8cc66) Merge pull request [#585](https://github-redirect.dependabot.com/serde-rs/json/issues/585) from Nilix007/add_from_unit_for_value - [`ff5a59c`](serde-rs/json@ff5a59c) Add `impl From\<()> for Value` - [`7dda823`](serde-rs/json@7dda823) Merge pull request [#580](https://github-redirect.dependabot.com/serde-rs/json/issues/580) from andrisak/docs_read_without_blocking_eof - [`2065227`](serde-rs/json@2065227) Added missing fake_main [#522](https://github-redirect.dependabot.com/serde-rs/json/issues/522) - [`3a5aba3`](serde-rs/json@3a5aba3) Fix for Document how to deserialize from a prefix of an io::Read without bloc... - [`0c72820`](serde-rs/json@0c72820) Ignore must_use_candidate pedantic lint - [`265f1ca`](serde-rs/json@265f1ca) Upgrade to rustversion 1.0 - [`b63ad14`](serde-rs/json@b63ad14) Address needless_doctest_main lint - See full diff in [compare view](serde-rs/json@v1.0.41...v1.0.42) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=serde_json&package-manager=cargo&previous-version=1.0.41&new-version=1.0.42) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: Calvin Lau <calvinlauco@gmail.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: Add network argument to to_cro()
to_cro()always encoded with the initialized network, making it mpossible to encode to arbitrary network