Skip to content
This repository was archived by the owner on Jul 27, 2022. It is now read-only.

Problem: tx-validation fails to compile#595

Closed
tomtau wants to merge 1 commit intocrypto-com:masterfrom
tomtau:fix/aead-version
Closed

Problem: tx-validation fails to compile#595
tomtau wants to merge 1 commit intocrypto-com:masterfrom
tomtau:fix/aead-version

Conversation

@tomtau
Copy link
Copy Markdown
Contributor

@tomtau tomtau commented Nov 18, 2019

Solution: fixed the version of aead crate

This was referenced Nov 18, 2019
Merged
Merged
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 18, 2019 •
edited
Loading

Codecov Report

Merging #595 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
- Coverage   67.42%   67.41%   -0.02%     
==========================================
  Files         125      125              
  Lines       14700    14700              
==========================================
- Hits         9912     9910       -2     
- Misses       4788     4790       +2
Impacted Files Coverage Δ
client-core/src/synchronizer/auto_synchronizer.rs 53.19% <0%> (-0.71%) ⬇️
chain-core/src/tx/fee/mod.rs 87.68% <0%> (-0.5%) ⬇️

@devashishdxt
Copy link
Copy Markdown
Contributor

devashishdxt commented Nov 18, 2019

bors r+

bors bot added a commit that referenced this pull request Nov 18, 2019
@bors @tomtau
Merge #595
7d781cf 
595: Problem: tx-validation fails to compile r=devashishdxt a=tomtau

Solution: fixed the version of aead crate

Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Nov 18, 2019

Build failed

@tomtau
Copy link
Copy Markdown
Contributor Author

tomtau commented Nov 18, 2019

probably will need to put a ^

@tomtau
Copy link
Copy Markdown
Contributor Author

tomtau commented Nov 18, 2019

bors retry

bors bot added a commit that referenced this pull request Nov 18, 2019
@bors @tomtau
Merge #595
0f07d74 
595: Problem: tx-validation fails to compile r=devashishdxt a=tomtau

Solution: fixed the version of aead crate

Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Nov 18, 2019

Build failed

@tomtau
Problem: tx-validation fails to compile
5d294b3 
Solution: fixed the version of aead crate
@lezzokafka
Copy link
Copy Markdown
Collaborator

lezzokafka commented Nov 18, 2019

Tried to build on my machine, got

 Compiling aes-gcm-siv v0.2.1
error[E0046]: not all trait items implemented, missing: `encrypt_in_place_detached`, `decrypt_in_place_detached`

similar to bors i guess

@tomtau
Copy link
Copy Markdown
Contributor Author

tomtau commented Nov 18, 2019

bors retry

bors bot added a commit that referenced this pull request Nov 18, 2019
@bors @tomtau
Merge #595
a505fff 
595: Problem: tx-validation fails to compile r=devashishdxt a=tomtau

Solution: fixed the version of aead crate

Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
devashishdxt
devashishdxt suggested changes Nov 18, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@devashishdxt devashishdxt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just put aead = "= 0.1.1" both in chain-tx-enclave/tx-validation/enclave/Cargo.toml and chain-core/Cargo.toml.

I have also created an issue with AEAD crate and it seems like they released a breaking change in a minor version and will probably yank this version.

@tomtau
Copy link
Copy Markdown
Contributor Author

tomtau commented Nov 18, 2019

I think we can just put aead = "= 0.1.1" both in chain-tx-enclave/tx-validation/enclave/Cargo.toml and chain-core/Cargo.toml.

I have also created an issue with AEAD crate and it seems like they released a breaking change in a minor version and will probably yank this version.

or start to use Cargo.lock on chain-tx-enclave/** stuff

@devashishdxt
Copy link
Copy Markdown
Contributor

devashishdxt commented Nov 18, 2019 •
edited
Loading

@tomtau They yanked v0.1.2. I don't know if we'll need this change anymore.

@tomtau
Copy link
Copy Markdown
Contributor Author

tomtau commented Nov 18, 2019

bors r-

@tomtau tomtau closed this Nov 18, 2019
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Nov 18, 2019

Canceled

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@leejw51crypto leejw51crypto Awaiting requested review from leejw51crypto

@linfeng-crypto linfeng-crypto Awaiting requested review from linfeng-crypto

4 more reviewers

@devashishdxt devashishdxt devashishdxt requested changes

@yihuang yihuang yihuang approved these changes

@calvinaco calvinaco calvinaco approved these changes

@lezzokafka lezzokafka lezzokafka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tomtau @devashishdxt @lezzokafka @yihuang @calvinaco