Problem: (CRO-582) Create transfer address is not re-usable#593
Problem: (CRO-582) Create transfer address is not re-usable#593bors[bot] merged 1 commit intocrypto-com:masterfrom calvinlauyh:feature/cro-582-reusable-new-transfer-address
Conversation
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
==========================================
+ Coverage 67.33% 67.41% +0.08%
==========================================
Files 125 126 +1
Lines 14675 14855 +180
==========================================
+ Hits 9881 10015 +134
- Misses 4794 4840 +46
|
|
bors try |
tryBuild failed |
|
bors retry |
tomtau
left a comment
There was a problem hiding this comment.
looks ok -- note that the multi-sig addresses can have more general conditions, e.g. there are signers A,B,C and it could be signed by either A or B&C... and this client API doesn't allow/expose that, but it could perhaps be added later when required?
|
@calvinlauco can you squash the commits? |
Yes, I agree. Flexible signing pairs can have a separate task for it. This task focus more on extracting and refactoring existing logic to be re-usable component.
Ok, will squash it now. |
Solution: Extract MultiSigAddress from root_hash service
|
bors r+ |
tryBuild failed |
|
bors retry |
|
Already running a review |
Merge conflict (retrying...) |
591: Problem: no transaction type for joining validator set (CRO-553) r=tomtau a=tomtau Solution: - consolidated ABCI node state to have one field dedicated to validate state tracking - added a NodeJoinTx type + basic validation code and tests - added a End block handling when the validator power changed or new nodes were changed -- based on the top validators after modifications, it computes the validator updates it needs to pass to tendermint - small steps in storage/tx.rs refactoring -- two verify functions to distinguish between abci-only and enclave-dependant transactions + moved out the huge functionality tests into a separate file NOTE: don't get scared about the PR size -- most of it is just moving `storage/tx.rs` tests into a separate file (it'll still need some improvements, but that can be done in a separate PR) 593: Problem: (CRO-582) Create transfer address is not re-usable r=tomtau a=calvinlauco Solution: Extracted MultiSigAddress from root_hash service to serve single responsibility --- Remarks: - This PR is a pre-requisite of the JS library by making components re-usable by JS - Removed n(total_signers) field because it is implied from len of public keys Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com> Co-authored-by: Calvin Lau <calvinlauco@gmail.com>
Build failed (retrying...) |
593: Problem: (CRO-582) Create transfer address is not re-usable r=tomtau a=calvinlauco Solution: Extracted MultiSigAddress from root_hash service to serve single responsibility --- Remarks: - This PR is a pre-requisite of the JS library by making components re-usable by JS - Removed n(total_signers) field because it is implied from len of public keys 598: Bump abci from 0.6.3 to 0.6.4 r=tomtau a=dependabot-preview[bot] Bumps [abci](https://github.com/tendermint/rust-abci) from 0.6.3 to 0.6.4. <details> <summary>Changelog</summary> *Sourced from [abci's changelog](https://github.com/tendermint/rust-abci/blob/develop/CHANGELOG.md).* > ## v0.6.4 > > ### IMPROVEMENTS: > > - [\#100](https://github-redirect.dependabot.com/tendermint/rust-abci/pull/100): worker panic propagated to the abci process > > _November 11, 2019_ </details> <details> <summary>Commits</summary> - See full diff in [compare view](https://github.com/tendermint/rust-abci/commits) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=abci&package-manager=cargo&previous-version=0.6.3&new-version=0.6.4) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: Calvin Lau <calvinlauco@gmail.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Solution: Extracted MultiSigAddress from root_hash service to serve single responsibility
Remarks: