Skip to content
This repository was archived by the owner on Jul 27, 2022. It is now read-only.

Problem: duplicate jailing/slashing test setup code. CRO-573#592

Merged
bors[bot] merged 1 commit intocrypto-com:masterfrom
yihuang:cro-573
Nov 15, 2019
Merged

Problem: duplicate jailing/slashing test setup code. CRO-573#592
bors[bot] merged 1 commit intocrypto-com:masterfrom
yihuang:cro-573

Conversation

@yihuang
Copy link
Copy Markdown
Contributor

@yihuang yihuang commented Nov 15, 2019 •
edited
Loading

Solution:
Refactored into more modular code.

Currently removed checking on validators of ResponseInitChain, because #584 will change that.

@yihuang yihuang requested a review from tomtau November 15, 2019 09:26
tomtau
tomtau approved these changes Nov 15, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

devashishdxt
devashishdxt approved these changes Nov 15, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@devashishdxt devashishdxt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

lezzokafka
lezzokafka approved these changes Nov 15, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lezzokafka lezzokafka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

Problem: duplicate jailing/slashing test setup code. CRO-573
2e6ace7 
Solution:
Refactored into more modular code.
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 15, 2019 •
edited
Loading

Codecov Report

Merging #592 into master will decrease coverage by 0.67%.
The diff coverage is 96.8%.

@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
- Coverage   68.09%   67.42%   -0.68%     
==========================================
  Files         124      125       +1     
  Lines       15016    14700     -316     
==========================================
- Hits        10225     9911     -314     
+ Misses       4791     4789       -2
Impacted Files Coverage Δ
chain-abci/tests/abci_app.rs 94.15% <100%> (-1.93%) ⬇️
chain-abci/tests/punishment.rs 96.77% <96.77%> (ø)
chain-core/src/common/merkle_tree.rs 98.55% <0%> (-0.25%) ⬇️

@tomtau
Copy link
Copy Markdown
Contributor

tomtau commented Nov 15, 2019

bors r+

bors bot added a commit that referenced this pull request Nov 15, 2019
@bors
Merge #592
1389770 
592: Problem: duplicate jailing/slashing test setup code. CRO-573 r=tomtau a=yihuang

Solution:
Refactored into more modular code.

Currently removed checking on validators of `ResponseInitChain`, because #584 will change that.

Co-authored-by: yihuang <huang@crypto.com>
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Nov 15, 2019

Build succeeded

@bors bors bot merged commit 2e6ace7 into crypto-com:master Nov 15, 2019
@yihuang yihuang deleted the cro-573 branch December 19, 2019 08:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tomtau tomtau Awaiting requested review from tomtau

@calvinaco calvinaco Awaiting requested review from calvinaco calvinaco is a code owner

@leejw51crypto leejw51crypto Awaiting requested review from leejw51crypto

@linfeng-crypto linfeng-crypto Awaiting requested review from linfeng-crypto

2 more reviewers

@devashishdxt devashishdxt devashishdxt approved these changes

@lezzokafka lezzokafka lezzokafka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yihuang @tomtau @devashishdxt @lezzokafka