This repository was archived by the owner on Jul 27, 2022. It is now read-only.
Problem: (CRO-392) Outdated dependencies in client's storage encryption#588
Merged
bors[bot] merged 1 commit intocrypto-com:masterfrom Nov 14, 2019
devashishdxt:client-enc-update
Merged
Problem: (CRO-392) Outdated dependencies in client's storage encryption#588bors[bot] merged 1 commit intocrypto-com:masterfrom devashishdxt:client-enc-update
bors[bot] merged 1 commit intocrypto-com:masterfrom
devashishdxt:client-enc-update
Conversation
Contributor
Author
|
bors try |
calvinaco
approved these changes
Nov 14, 2019
Contributor
tryBuild failed |
Contributor
the client stores structured data (not only random seeds / private keys), so with potentially weak passphrases, it could be useful to slow down brute-forcing. |
Contributor
|
bors r+ |
Contributor
Author
For this, we can just append a random |
bors bot
added a commit
that referenced
this pull request
Nov 14, 2019
580: Bump unicase from 2.5.1 to 2.6.0 r=tomtau a=dependabot-preview[bot] Bumps [unicase](https://github.com/seanmonstar/unicase) from 2.5.1 to 2.6.0. <details> <summary>Release notes</summary> *Sourced from [unicase's releases](https://github.com/seanmonstar/unicase/releases).* > ## v2.6.0 > - Fix `UniCase::eq` in Unicode mode so that it doesn't equal a substring of the other. > - Make crate `no_std`. </details> <details> <summary>Commits</summary> - [`7b116bc`](seanmonstar/unicase@7b116bc) v2.6.0 - [`c14856b`](seanmonstar/unicase@c14856b) Fix Unicode::eq to not equal when one side is a substring of the other ([#39](https://github-redirect.dependabot.com/seanmonstar/unicase/issues/39)) - [`4788cba`](seanmonstar/unicase@4788cba) update version_check - [`fbab380`](seanmonstar/unicase@fbab380) Implement no_std support ([#34](https://github-redirect.dependabot.com/seanmonstar/unicase/issues/34)) - See full diff in [compare view](seanmonstar/unicase@v2.5.1...v2.6.0) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=unicase&package-manager=cargo&previous-version=2.5.1&new-version=2.6.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> 588: Problem: (CRO-392) Outdated dependencies in client's storage encryption r=tomtau a=devashishdxt Solution: Use `aes-gcm-siv` for encryption/decryption Note: Turns out that the root cause of timeouts was password hashing using `rust-argon2` which, as far as I know, is only useful when we want to store passwords in a database. Adding cache for wallet details is still a good idea and can be done in a different task. Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Devashish Dixit <devashish@crypto.com>
Codecov Report
@@ Coverage Diff @@
## master #588 +/- ##
==========================================
+ Coverage 67.73% 67.75% +0.02%
==========================================
Files 124 124
Lines 14785 14776 -9
==========================================
- Hits 10015 10012 -3
+ Misses 4770 4764 -6
|
Contributor
|
bors r- |
Contributor
Canceled |
tomtau
suggested changes
Nov 14, 2019
leejw51crypto
approved these changes
Nov 14, 2019
Solution: Use aes-gcm-siv for encryption/decryption
Contributor
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 14, 2019
588: Problem: (CRO-392) Outdated dependencies in client's storage encryption r=tomtau a=devashishdxt Solution: Use `aes-gcm-siv` for encryption/decryption Note: Turns out that the root cause of timeouts was password hashing using `rust-argon2` which, as far as I know, is only useful when we want to store passwords in a database. Adding cache for wallet details is still a good idea and can be done in a different task. Co-authored-by: Devashish Dixit <devashish@crypto.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: Use
aes-gcm-sivfor encryption/decryptionNote: Turns out that the root cause of timeouts was password hashing using
rust-argon2which, as far as I know, is only useful when we want to store passwords in a database. Adding cache for wallet details is still a good idea and can be done in a different task.