Problem:(CRO-574) integration test cannot run on linux by leejw51crypto · Pull Request #579 · crypto-com/thaler

leejw51crypto · 2019-11-12T10:49:46Z

Solution: add fixes for linux
fix env error

add sudo

leejw51crypto · 2019-11-12T10:52:35Z

you can activate integration test on linux , mac
like this

export SGX_MODE=sw
export NETWORK_ID = ab
export USE_DOCKER_COMPOSE= 1


cd integration-tests
./prepare.sh
. ./env.sh
docker-compose up

cd integration-tests
cd client-rpc
yarn
yarn test

leejw51crypto · 2019-11-12T10:52:52Z

thanks @calvinaco @tomtau

leejw51crypto · 2019-11-12T10:53:46Z

getting scripts' absolute path is necessary,
in non interactive shell,
it's -bash <- $0

integration-tests/env.sh

leejw51 · 2019-11-12T12:01:17Z

integration-tests/prepare.sh

    print_step "Cloning Tendermint config from \"${1}\" to \"${2}\""

-    rm -rf "${2}"
+    sudo rm -rf "${2}"


in travis, it is no problem, because it's root.
so i added sudo for these commands.

why is sudo required?

because in running,
./prepare.sh
it makes root owned file inside docker,
so external shell is normal user,
it cannot continue

i didn't execute as root and it worked fine

@calvinaco @calvinlauco is sudo really required?

which folder did you run the script?
for me, i ran inside intergration_tests folder.
cd integrations-tests
./prepare.sh

for me, it always fails to compile

doing sudo also seems overkill; maybe after each generated docker-data, try to change the ownership to the current user?

agree, i will try different approach

codecov · 2019-11-12T13:06:42Z

Codecov Report

Merging #579 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #579   +/-   ##
=======================================
  Coverage   67.73%   67.73%           
=======================================
  Files         124      124           
  Lines       14785    14785           
=======================================
  Hits        10015    10015           
  Misses       4770     4770

tomtau

i don't think sudo should be required for running integration tests -- also, here sudo was inserted in front of rm -rf <some env variable> which looks dangerous, especially as there are no checks on if these environment variables were set properly

leejw51crypto · 2019-11-13T06:12:27Z

ok, i will find a way to bypass

leejw51crypto · 2019-11-13T09:08:40Z

removed sudo,
chmod ug+s docker-data

tomtau

seems ok -- can you squash the commits?

leejw51crypto · 2019-11-13T11:32:40Z

ok, i will

Solution: add fixes for linux fix env error add sudo add -- option add -- option remove sudo restore wallet client remove hdwallet test remove hdwallet test fix copy error

leejw51crypto · 2019-11-13T11:51:15Z

done!
good to go

tomtau · 2019-11-14T00:30:38Z

bors r+

579: Problem:(CRO-574) integration test cannot run on linux r=tomtau a=leejw51crypto Solution: add fixes for linux fix env error add sudo 580: Bump unicase from 2.5.1 to 2.6.0 r=tomtau a=dependabot-preview[bot] Bumps [unicase](https://github.com/seanmonstar/unicase) from 2.5.1 to 2.6.0. <details> <summary>Release notes</summary> *Sourced from [unicase's releases](https://github.com/seanmonstar/unicase/releases).* > ## v2.6.0 > - Fix `UniCase::eq` in Unicode mode so that it doesn't equal a substring of the other. > - Make crate `no_std`. </details> <details> <summary>Commits</summary> - [`7b116bc`](seanmonstar/unicase@7b116bc) v2.6.0 - [`c14856b`](seanmonstar/unicase@c14856b) Fix Unicode::eq to not equal when one side is a substring of the other ([#39](https://github-redirect.dependabot.com/seanmonstar/unicase/issues/39)) - [`4788cba`](seanmonstar/unicase@4788cba) update version_check - [`fbab380`](seanmonstar/unicase@fbab380) Implement no_std support ([#34](https://github-redirect.dependabot.com/seanmonstar/unicase/issues/34)) - See full diff in [compare view](seanmonstar/unicase@v2.5.1...v2.6.0) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=unicase&package-manager=cargo&previous-version=2.5.1&new-version=2.6.0)](https://dependabot.com/compatibility-score.html?dependency-name=unicase&package-manager=cargo&previous-version=2.5.1&new-version=2.6.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> 584: Problem: client can't trust validators field in genesis api (CRO-101) r=tomtau a=yihuang Solution: Validate validators in ``RequestInitChain``, make sure the consistency. Co-authored-by: jongwhan lee <leejw51@gmail.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: yihuang <huang@crypto.com>

bors · 2019-11-14T02:04:25Z

Build failed (retrying...)

continuous-integration/travis-ci/push

579: Problem:(CRO-574) integration test cannot run on linux r=tomtau a=leejw51crypto Solution: add fixes for linux fix env error add sudo Co-authored-by: jongwhan lee <leejw51@gmail.com>

bors · 2019-11-14T02:39:37Z

Build failed

continuous-integration/drone/push

tomtau · 2019-11-14T04:52:19Z

bors r+

579: Problem:(CRO-574) integration test cannot run on linux r=tomtau a=leejw51crypto Solution: add fixes for linux fix env error add sudo Co-authored-by: jongwhan lee <leejw51@gmail.com>

bors · 2019-11-14T06:42:32Z

Build succeeded

leejw51 reviewed Nov 12, 2019

View reviewed changes

integration-tests/env.sh Outdated Show resolved Hide resolved

leejw51 reviewed Nov 12, 2019

View reviewed changes

tomtau requested review from calvinaco, devashishdxt, lezzokafka, linfeng-crypto, tomtau and yihuang November 12, 2019 12:15

tomtau suggested changes Nov 13, 2019

View reviewed changes

leejw51 force-pushed the cro-574 branch 2 times, most recently from cebe902 to d1ebf10 Compare November 13, 2019 03:15

tomtau changed the title ~~Problem:(CRO-574) integration test not compiled on linux~~ Problem:(CRO-574) integration test cannot run on linux Nov 13, 2019

tomtau self-requested a review November 13, 2019 10:40

tomtau suggested changes Nov 13, 2019

View reviewed changes

leejw51 force-pushed the cro-574 branch 4 times, most recently from 4babf8b to 977f5e2 Compare November 13, 2019 11:40

Problem:(CRO-574) integration test not compiled on linux

4971789

Solution: add fixes for linux fix env error add sudo add -- option add -- option remove sudo restore wallet client remove hdwallet test remove hdwallet test fix copy error

leejw51 force-pushed the cro-574 branch from 977f5e2 to 4971789 Compare November 13, 2019 11:47

calvinaco approved these changes Nov 14, 2019

View reviewed changes

bors bot added a commit that referenced this pull request Nov 14, 2019

Merge #579

ba8dc49

579: Problem:(CRO-574) integration test cannot run on linux r=tomtau a=leejw51crypto Solution: add fixes for linux fix env error add sudo Co-authored-by: jongwhan lee <leejw51@gmail.com>

bors bot added a commit that referenced this pull request Nov 14, 2019

Merge #579

227325b

579: Problem:(CRO-574) integration test cannot run on linux r=tomtau a=leejw51crypto Solution: add fixes for linux fix env error add sudo Co-authored-by: jongwhan lee <leejw51@gmail.com>

bors bot merged commit 4971789 into crypto-com:master Nov 14, 2019

Conversation

leejw51crypto commented Nov 12, 2019

Uh oh!

leejw51crypto commented Nov 12, 2019

Uh oh!

leejw51crypto commented Nov 12, 2019

Uh oh!

leejw51crypto commented Nov 12, 2019

Uh oh!

Uh oh!

leejw51 Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

tomtau Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

leejw51crypto Nov 13, 2019

Choose a reason for hiding this comment

Uh oh!

tomtau Nov 13, 2019

Choose a reason for hiding this comment

Uh oh!

tomtau Nov 13, 2019

Choose a reason for hiding this comment

Uh oh!

leejw51crypto Nov 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

calvinaco Nov 13, 2019

Choose a reason for hiding this comment

Uh oh!

leejw51crypto Nov 13, 2019

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Nov 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tomtau left a comment

Choose a reason for hiding this comment

Uh oh!

leejw51crypto commented Nov 13, 2019

Uh oh!

leejw51crypto commented Nov 13, 2019

Uh oh!

tomtau left a comment

Choose a reason for hiding this comment

Uh oh!

leejw51crypto commented Nov 13, 2019

Uh oh!

leejw51crypto commented Nov 13, 2019

Uh oh!

tomtau commented Nov 14, 2019

Uh oh!

bors bot commented Nov 14, 2019

Build failed (retrying...)

Uh oh!

bors bot commented Nov 14, 2019

Build failed

Uh oh!

tomtau commented Nov 14, 2019

Uh oh!

bors bot commented Nov 14, 2019

Build succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

leejw51crypto Nov 13, 2019 •

edited

Loading

codecov bot commented Nov 12, 2019 •

edited

Loading