This repository was archived by the owner on Jul 27, 2022. It is now read-only.
Problem: (CRO-562) tiny-keccak 2.0 fails to compile#576
Merged
bors[bot] merged 1 commit intocrypto-com:masterfrom Nov 12, 2019
devashishdxt:keccak-2.0
Merged
Problem: (CRO-562) tiny-keccak 2.0 fails to compile#576bors[bot] merged 1 commit intocrypto-com:masterfrom devashishdxt:keccak-2.0
bors[bot] merged 1 commit intocrypto-com:masterfrom
devashishdxt:keccak-2.0
Conversation
Solution: Made necessary changes for `tiny-keccak = 2.0`
tomtau
reviewed
Nov 12, 2019
Contributor
|
bors try |
Contributor
|
bors cancel |
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
==========================================
- Coverage 67.49% 67.49% -0.01%
==========================================
Files 124 124
Lines 14363 14365 +2
==========================================
+ Hits 9695 9696 +1
- Misses 4668 4669 +1
|
bors bot
added a commit
that referenced
this pull request
Nov 12, 2019
535: Problem: (CRO-392) outdated dependencies in client's storage encryption r=tomtau a=linfeng-crypto Solution: - use crate `aes-gcm-siv` and `aead` instead of `miscreant` - use crate `rust-argon2` to the `passphrase` to a constant length, and store the `salt` at the end of the encrypted data. 576: Problem: (CRO-562) tiny-keccak 2.0 fails to compile r=tomtau a=devashishdxt Solution: Made necessary changes for `tiny-keccak = 2.0` Co-authored-by: ylf <cxwcylf@126.com> Co-authored-by: Devashish Dixit <devashish@crypto.com>
Contributor
tryBuild succeeded |
Contributor
Build failed (retrying...) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: Made necessary changes for
tiny-keccak = 2.0