This repository was archived by the owner on Jul 27, 2022. It is now read-only.
Problem: (CRO-494) not possible to create unjail transaction in client-cli#552
Closed
leejw51 wants to merge 1 commit intocrypto-com:masterfrom
Closed
Problem: (CRO-494) not possible to create unjail transaction in client-cli#552leejw51 wants to merge 1 commit intocrypto-com:masterfrom
leejw51 wants to merge 1 commit intocrypto-com:masterfrom
Conversation
Collaborator
|
confirmed it is working fine with 4 nodes using HW enclave |
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
==========================================
- Coverage 67.39% 67.24% -0.15%
==========================================
Files 122 122
Lines 14203 14167 -36
==========================================
- Hits 9572 9527 -45
- Misses 4631 4640 +9
|
tomtau
suggested changes
Nov 5, 2019
Contributor
tomtau
left a comment
There was a problem hiding this comment.
I think this solves a different problem -- "Problem: not possible to create unjail transaction in client-cli" or something like that?
calvinaco
approved these changes
Nov 5, 2019
Collaborator
|
This PR is more for creating an unjail Tx, which can become part of CRO-494;
====Node supposed to be jailed ====
====At the end of
|
lezzokafka
approved these changes
Nov 5, 2019
Contributor
|
bors r+ |
Contributor
Canceled |
…t-cli Solution: call unjail in cli increase coverage
Contributor
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 5, 2019
552: Problem: (CRO-494) not possible to create unjail transaction in client-cli r=tomtau a=leejw51 Solution: call unjail in cli 555: Problem: (CRO-538) Caching is too huge and timeout exceeded in Travis r=tomtau a=calvinlauco Solution: Disable caching in nightly and increase test allowed timeout Co-authored-by: Jongwhan Lee <jonghwan@crypto.com> Co-authored-by: Calvin Lau <calvinlauco@gmail.com>
Collaborator
|
wallet bug |
Contributor
Timed out (retrying...) |
Contributor
Timed out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: call unjail in cli