This repository was archived by the owner on Jul 27, 2022. It is now read-only.
Problem: app hash changes even if app state didn't change (CRO-526)#542
Merged
bors[bot] merged 1 commit intocrypto-com:masterfrom Oct 31, 2019
Merged
Problem: app hash changes even if app state didn't change (CRO-526)#542bors[bot] merged 1 commit intocrypto-com:masterfrom
bors[bot] merged 1 commit intocrypto-com:masterfrom
Conversation
Solution: added a flag to chainabci node to signal whether rewards pool was updated in that block (either by slashing events or transaction fees -- in the future reward distribution), so that its "last_block_height" (which denotes when it was updated last time) is only updated when the amount changed. TODO: perhaps move the rewards pool update logic to rewards pool code (rather than in abci)?
devashishdxt
approved these changes
Oct 31, 2019
Contributor
Author
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 31, 2019
537: Problem: (CRO-294) Client can generate invalid transactions r=tomtau a=devashishdxt Solution: Added balance checks when creating network ops transactions 542: Problem: app hash changes even if app state didn't change (CRO-526) r=tomtau a=tomtau Solution: added a flag to chainabci node to signal whether rewards pool was updated in that block (either by slashing events or transaction fees -- in the future reward distribution), so that its "last_block_height" (which denotes when it was updated last time) is only updated when the amount changed. TODO: perhaps move the rewards pool update logic to rewards pool code (rather than in abci)? Co-authored-by: Devashish Dixit <devashish@crypto.com> Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
==========================================
+ Coverage 67.23% 67.24% +0.01%
==========================================
Files 122 122
Lines 14102 14107 +5
==========================================
+ Hits 9481 9486 +5
Misses 4621 4621
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: added a flag to chainabci node to signal whether rewards pool was updated
in that block (either by slashing events or transaction fees -- in the future reward distribution),
so that its "last_block_height" (which denotes when it was updated last time)
is only updated when the amount changed.
TODO: perhaps move the rewards pool update logic to rewards pool code (rather than in abci)?