This repository was archived by the owner on Jul 27, 2022. It is now read-only.
Problem: (CRO-501) Integration tests is not running in HW SGX#540
Merged
bors[bot] merged 1 commit intocrypto-com:masterfrom Oct 31, 2019
calvinlauyh:feature/cro-501-drone-sgx-integration-tests
Merged
Problem: (CRO-501) Integration tests is not running in HW SGX#540bors[bot] merged 1 commit intocrypto-com:masterfrom calvinlauyh:feature/cro-501-drone-sgx-integration-tests
bors[bot] merged 1 commit intocrypto-com:masterfrom
calvinlauyh:feature/cro-501-drone-sgx-integration-tests
Conversation
Contributor
Author
|
bors try |
Contributor
|
🔒 Permission denied Existing reviewers: click here to make calvinlauco a reviewer |
Collaborator
|
bors try |
leejw51crypto
approved these changes
Oct 30, 2019
Contributor
tryBuild failed |
Contributor
Author
|
Enclave is not building correctly in Travis, I will fix it first. |
Codecov Report
@@ Coverage Diff @@
## master #540 +/- ##
=======================================
Coverage 67.23% 67.23%
=======================================
Files 122 122
Lines 14102 14102
=======================================
Hits 9481 9481
Misses 4621 4621 |
Collaborator
|
bors try |
Contributor
tryTimed out |
tomtau
approved these changes
Oct 31, 2019
Contributor
tomtau
left a comment
There was a problem hiding this comment.
lgtm -- I'll create another PR to restrict the new exec pipeline + sign
| commands: | ||
| - mkdir bin | ||
| - export PATH="$PATH:$PWD/bin" | ||
| - curl -sSL "https://github.com/docker/compose/releases/download/1.24.1/docker-compose-$(uname -s)-$(uname -m)" -o bin/docker-compose |
Contributor
There was a problem hiding this comment.
there's no docker compose installed?
Contributor
Author
There was a problem hiding this comment.
No, it doesn’t. At least not available for drone executing user. We could install it and save time downloading it every time tests run.
Contributor
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 31, 2019
537: Problem: (CRO-294) Client can generate invalid transactions r=tomtau a=devashishdxt Solution: Added balance checks when creating network ops transactions 538: Problem:(CRO-521) Problem: unbonded from custom time is ignored in genesis initconfig r=tomtau a=linfeng-crypto Solution: change the parameters of `new_init`: change `genesis_time` from `Timespec` into `Option<Timespec>`, remove the `bool` type parameter `bonded`, add a `&StakedStateDestination` type parameter. 540: Problem: (CRO-501) Integration tests is not running in HW SGX r=tomtau a=calvinlauco Solution: Add integration tests in Drone CI running in HW SGX --- - Integration tests will run as SW mode in TravisCI and HW mode in Drone Co-authored-by: Devashish Dixit <devashish@crypto.com> Co-authored-by: linfeng <linfeng@crypto.com> Co-authored-by: Calvin Lau <calvinlauco@gmail.com>
Contributor
Build failed (retrying...) |
Solution: Add integration tests in Drone CI running in HW SGX
Contributor
Canceled |
Contributor
|
bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: Add integration tests in Drone CI running in HW SGX