Skip to content
This repository was archived by the owner on Jul 27, 2022. It is now read-only.

Problem: outdated secp256k1 fork dependency#528

Merged
bors[bot] merged 1 commit intocrypto-com:masterfrom
tomtau:bump/secp256k1
Oct 28, 2019
Merged

Problem: outdated secp256k1 fork dependency#528
bors[bot] merged 1 commit intocrypto-com:masterfrom
tomtau:bump/secp256k1

Conversation

@tomtau
Copy link
Copy Markdown
Contributor

@tomtau tomtau commented Oct 28, 2019

Solution: migrated to the last ported version + re-generated Cargo.lock

This was referenced Oct 28, 2019
Closed
Closed
Closed
Closed
@tomtau
Copy link
Copy Markdown
Contributor Author

tomtau commented Oct 28, 2019

bors r+

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Oct 28, 2019

Merge conflict (retrying...)

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 28, 2019 •
edited
Loading

Codecov Report

Merging #528 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
- Coverage   67.31%   67.31%   -0.01%     
==========================================
  Files         120      120              
  Lines       14158    14158              
==========================================
- Hits         9531     9530       -1     
- Misses       4627     4628       +1
Impacted Files Coverage Δ
chain-core/src/common/merkle_tree.rs 98.78% <0%> (-0.25%) ⬇️

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Oct 28, 2019

Canceled

@tomtau
Copy link
Copy Markdown
Contributor Author

tomtau commented Oct 28, 2019

bors r+

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Oct 28, 2019

Merge conflict (retrying...)

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Oct 28, 2019

Canceled

@tomtau
Copy link
Copy Markdown
Contributor Author

tomtau commented Oct 28, 2019

bors r+

bors bot added a commit that referenced this pull request Oct 28, 2019
@bors @tomtau
Merge #528
8fa9ae8 
528: Problem: outdated secp256k1 fork dependency r=tomtau a=tomtau

Solution: migrated to the last ported version + re-generated Cargo.lock

Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Oct 28, 2019

Build failed

@tomtau
Problem: outdated secp256k1 fork dependency
15a5a20 
Solution: migrated to the last ported version + re-generated Cargo.lock
@tomtau
Copy link
Copy Markdown
Contributor Author

tomtau commented Oct 28, 2019

bors r+

bors bot added a commit that referenced this pull request Oct 28, 2019
@bors @tomtau
Merge #528
b63773e 
528: Problem: outdated secp256k1 fork dependency r=tomtau a=tomtau

Solution: migrated to the last ported version + re-generated Cargo.lock

Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Oct 28, 2019

Build succeeded

@bors bors bot merged commit 15a5a20 into crypto-com:master Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devashishdxt devashishdxt Awaiting requested review from devashishdxt

@lezzokafka lezzokafka Awaiting requested review from lezzokafka

@linfeng-crypto linfeng-crypto Awaiting requested review from linfeng-crypto

2 more reviewers

@calvinaco calvinaco calvinaco approved these changes

@leejw51crypto leejw51crypto leejw51crypto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomtau @calvinaco @leejw51crypto