Problem:(CRO-479) no HD wallet support in client-rpc by leejw51crypto · Pull Request #486 · crypto-com/thaler

leejw51crypto · 2019-10-18T08:53:55Z

Solution: add hdwallet api to client-rpc

devashishdxt · 2019-10-18T08:55:34Z

client-rpc/src/rpc/wallet_rpc.rs

+    #[rpc(name = "wallet_create_hd")]
+    fn create_hd(&self, request: WalletRequest) -> Result<String>;


Can we update current wallet_create RPC call to take WalletType as an additional parameter instead of creating a new RPC method?

codecov · 2019-10-18T09:28:11Z

Codecov Report

Merging #486 into master will increase coverage by 0.63%.
The diff coverage is 95.53%.

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
+ Coverage   66.34%   66.98%   +0.63%     
==========================================
  Files         120      120              
  Lines       13909    14008      +99     
==========================================
+ Hits         9228     9383     +155     
+ Misses       4681     4625      -56

Impacted Files	Coverage Δ
client-core/src/types/wallet_kind.rs	`7.69% <100%> (-0.65%)`	⬇️
client-rpc/src/rpc/wallet_rpc.rs	`73.68% <95.49%> (+16.87%)`	⬆️
client-core/src/service/key_service.rs	`92.15% <0%> (+1.47%)`	⬆️
client-common/src/key/public_key.rs	`78.89% <0%> (+2.75%)`	⬆️
client-core/src/wallet/default_wallet_client.rs	`54.45% <0%> (+8.91%)`	⬆️
client-core/src/input_selection.rs	`72.72% <0%> (+72.72%)`	⬆️

client-rpc/src/rpc/wallet_rpc.rs

tomtau · 2019-10-19T01:13:29Z

bors r+

486: Problem:(CRO-479) no HD wallet support in client-rpc r=tomtau a=leejw51crypto Solution: add hdwallet api to client-rpc Co-authored-by: Jongwhan Lee <jonghwan@crypto.com>

bors · 2019-10-19T02:00:30Z

Build failed

continuous-integration/travis-ci/push

tomtau

integration test doesn't pass -- probably needs some fixes?

leejw51crypto · 2019-10-21T01:55:29Z

it's lack of unit test coverage.
i'll add more unit test

tomtau · 2019-10-21T02:33:55Z

@leejw51 @leejw51crypto the existing tests don't pass: https://travis-ci.org/crypto-com/chain/jobs/599922522#L5135

 1) Staking
5138       unbond of same amount and nonce from different account should have different txid:
5139     Invalid params: invalid length 1, expected a tuple of size 2.
5140  
5141
5142  2) Staking
5143       should support staking, unbonding and withdrawing:
5144     Invalid params: invalid length 1, expected a tuple of size 2.
5145  
5146
5147  3) Wallet Auto-sync
5148       can auto-sync unlocked wallets:
5149     Error: Error when creating receiver wallet: Invalid params: invalid length 1, expected a tuple of size 2.
5150      at Object.exports.asyncMiddleman (test/core/utils.ts:81:9)
5151      at process._tickCallback (internal/process/next_tick.js:68:7)
5152
5153  4) Wallet management
5154       can create wallet with specified name:
5155     Invalid params: invalid length 1, expected a tuple of size 2.
5156  
5157
5158  5) Wallet management
5159       Newly created wallet has a staking and transfer address associated:
5160     Invalid params: invalid length 1, expected a tuple of size 2.
5161  
5162
5163  6) Wallet management
5164       cannot create duplicated wallet:
5165     Invalid params: invalid length 1, expected a tuple of size 2.
5166  
5167
5168  7) Wallet management
5169       User cannot access wallet with incorrect passphrase:
5170     Invalid params: invalid length 1, expected a tuple of size 2.
5171  
5172
5173  8) Wallet management
5174       Create a transfer address and then list it:
5175     Invalid params: invalid length 1, expected a tuple of size 2.
5176  
5177
5178  9) Wallet management
5179       Create a staking address and then list it:
5180     Invalid params: invalid length 1, expected a tuple of size 2.
5181  
5182
5183  10) Wallet transaction
5184       Zero Fee
5185         can transfer funds between two wallets:
5186     Error: Error when creating receiver wallet: Invalid params: invalid length 1, expected a tuple of size 2.
5187      at Object.exports.asyncMiddleman (test/core/utils.ts:81:9)
5188      at process._tickCallback (internal/process/next_tick.js:68:7)
5189
5190  11) Wallet transaction
5191       With Fee
5192         can transfer funds between two wallets with fee included:
5193     Error: Error when creating receive wallet: Invalid params: invalid length 1, expected a tuple of size 2.
5194      at Object.exports.asyncMiddleman (test/core/utils.ts:81:9)
5195      at process._tickCallback (internal/process/next_tick.js:68:7)

@calvinaco

leejw51crypto · 2019-10-21T06:01:00Z

i'm working on intergration test

fix hdwallet creation tidy up replace String with SecUtf8 fix unit test add unit test add unit test for send amount fix integration test

leejw51 · 2019-10-22T02:33:26Z

fix integration test , giving wallet type "Basic" in calling "create wallet" like this

withFeeRpcClient.request("wallet_create", [receiverWalletRequest,"Basic"])

i added

"Basic"

thanks @calvinaco

tomtau · 2019-10-22T02:45:33Z

bors try

bors · 2019-10-22T03:52:55Z

try

Build succeeded

tomtau · 2019-10-22T03:53:21Z

bors r+

486: Problem:(CRO-479) no HD wallet support in client-rpc r=tomtau a=leejw51crypto Solution: add hdwallet api to client-rpc 501: Problem: unrestricted drone exec pipeline r=tomtau a=tomtau Solution: added trigger conditions, such that "exec" pipelines are only executed after bors actions Co-authored-by: Jongwhan Lee <jonghwan@crypto.com> Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>

bors · 2019-10-22T05:38:48Z

Build succeeded

tomtau requested review from calvinaco, devashishdxt, lezzokafka and tomtau October 18, 2019 08:54

devashishdxt suggested changes Oct 18, 2019

View reviewed changes

leejw51crypto force-pushed the cro-479 branch from 60a8bfd to 7d99401 Compare October 18, 2019 09:33

tomtau suggested changes Oct 18, 2019

View reviewed changes

client-rpc/src/rpc/wallet_rpc.rs Outdated Show resolved Hide resolved

leejw51crypto force-pushed the cro-479 branch from 7d99401 to e746094 Compare October 18, 2019 15:03

leejw51 force-pushed the cro-479 branch from e746094 to 05f03b1 Compare October 18, 2019 15:04

leejw51crypto force-pushed the cro-479 branch from 05f03b1 to d6e9543 Compare October 18, 2019 15:47

bors bot added a commit that referenced this pull request Oct 19, 2019

Merge #486

024f3b0

486: Problem:(CRO-479) no HD wallet support in client-rpc r=tomtau a=leejw51crypto Solution: add hdwallet api to client-rpc Co-authored-by: Jongwhan Lee <jonghwan@crypto.com>

tomtau self-requested a review October 20, 2019 06:07

tomtau suggested changes Oct 20, 2019

View reviewed changes

leejw51crypto force-pushed the cro-479 branch 3 times, most recently from 8b36b49 to ef0b13f Compare October 21, 2019 04:27

Problem:(CRO-479) no HD wallet support in client-rpc

81d0a55

fix hdwallet creation tidy up replace String with SecUtf8 fix unit test add unit test add unit test for send amount fix integration test

leejw51crypto force-pushed the cro-479 branch from ef0b13f to 81d0a55 Compare October 22, 2019 02:32

bors bot added a commit that referenced this pull request Oct 22, 2019

Try #486:

6eac9de

bors bot merged commit 81d0a55 into crypto-com:master Oct 22, 2019

		#[rpc(name = "wallet_create_hd")]
		fn create_hd(&self, request: WalletRequest) -> Result<String>;

Conversation

leejw51crypto commented Oct 18, 2019

Uh oh!

devashishdxt Oct 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

leejw51crypto Oct 18, 2019

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

tomtau commented Oct 19, 2019

Uh oh!

bors bot commented Oct 19, 2019

Build failed

Uh oh!

tomtau left a comment

Choose a reason for hiding this comment

Uh oh!

leejw51crypto commented Oct 21, 2019

Uh oh!

tomtau commented Oct 21, 2019

Uh oh!

leejw51crypto commented Oct 21, 2019

Uh oh!

leejw51 commented Oct 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomtau commented Oct 22, 2019

Uh oh!

bors bot commented Oct 22, 2019

try

Build succeeded

Uh oh!

tomtau commented Oct 22, 2019

Uh oh!

bors bot commented Oct 22, 2019

Build succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

devashishdxt Oct 18, 2019 •

edited

Loading

codecov bot commented Oct 18, 2019 •

edited

Loading

leejw51 commented Oct 22, 2019 •

edited

Loading