This repository was archived by the owner on Jul 27, 2022. It is now read-only.
Problem: (CRO-280) chain-abci init panics with raw genesis hash rather than hex-encoded#478
Merged
bors[bot] merged 1 commit intocrypto-com:masterfrom Oct 17, 2019
Merged
Conversation
devashishdxt
approved these changes
Oct 17, 2019
calvinaco
approved these changes
Oct 17, 2019
leejw51crypto
approved these changes
Oct 17, 2019
tomtau
suggested changes
Oct 17, 2019
Contributor
tomtau
left a comment
There was a problem hiding this comment.
a small formatting issue (should be fixable with cargo fmt): https://travis-ci.org/crypto-com/chain/jobs/598970683#L1549
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
=========================================
- Coverage 65.55% 65.5% -0.05%
=========================================
Files 117 117
Lines 13516 13525 +9
=========================================
Hits 8860 8860
- Misses 4656 4665 +9
|
Contributor
|
@linfeng-crypto looks ok, just squash the commit |
cf2cc19 to
4fa451e
Compare
Contributor
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 17, 2019
478: Problem: (CRO-280) chain-abci init panics with raw genesis hash rather than hex-encoded r=tomtau a=linfeng-crypto
Solution:
1. encode the raw hash data into string
2. if the raw hash is None, use "None"
3. make the log into a single line
4. use "{}" instead of "{:?}" in string format
479: Problem: HW-mode SGX tests not executed in CI (CRO-204) r=tomtau a=tomtau
Solution: added additional drone pipeline that executes the basic tx-validation test in HW mode
482: Problem: (CRO-493) Compilation fails with sled 0.29.1 r=tomtau a=devashishdxt
Solution: Updated sled to latest version and made all the required changes
Co-authored-by: linfeng.yuan <linfeng@crypto.com>
Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
Co-authored-by: Devashish Dixit <devashish@crypto.com>
Contributor
Build failed (retrying...) |
bors bot
added a commit
that referenced
this pull request
Oct 17, 2019
478: Problem: (CRO-280) chain-abci init panics with raw genesis hash rather than hex-encoded r=tomtau a=linfeng-crypto
Solution:
1. encode the raw hash data into string
2. if the raw hash is None, use "None"
3. make the log into a single line
4. use "{}" instead of "{:?}" in string format
Co-authored-by: linfeng.yuan <linfeng@crypto.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: