This repository was archived by the owner on Jul 27, 2022. It is now read-only.
Problem: (CRO-488) client-cli depends on an unmaintained library#476
Merged
bors[bot] merged 1 commit intocrypto-com:masterfrom Oct 16, 2019
devashishdxt:cli-table
Merged
Problem: (CRO-488) client-cli depends on an unmaintained library#476bors[bot] merged 1 commit intocrypto-com:masterfrom devashishdxt:cli-table
bors[bot] merged 1 commit intocrypto-com:masterfrom
devashishdxt:cli-table
Conversation
Solution: Client CLI depends on `prettytable-rs` which depends on `term` (which is an unmaintained library). Use `cli-table` instead of `prettytable-rs`
leejw51crypto
approved these changes
Oct 16, 2019
calvinaco
approved these changes
Oct 16, 2019
Contributor
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 16, 2019
471: Problem: (CRO-482) jsonrpc-core/http-server 14.0 fails to compile r=tomtau a=devashishdxt Solution: Changed `jsonrpc-core`/`jsonrpc-http-server` version to `14.0` 472: Problem: tx-query enclave doesn't support encryption requests (CRO-478) r=tomtau a=tomtau Solution: extended the enclave protocol, so that tx-query has some basic handling of encryption requests (mock keys atm); extended client-core's default communication with tx-query enclave NOTE: client<->tx-query enclave communication is tested if tx-query enclave is compiled with SGX_TEST=1 (currently only tests decryption query; encryption is TODO) 476: Problem: (CRO-488) client-cli depends on an unmaintained library r=tomtau a=devashishdxt Solution: Client CLI depends on `prettytable-rs` which depends on `term` (which is an unmaintained library). Use `cli-table` instead of `prettytable-rs`. Co-authored-by: Devashish Dixit <devashish@crypto.com> Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: Client CLI depends on
prettytable-rswhich depends onterm(which is an unmaintained library). Usecli-tableinstead ofprettytable-rs.