Update create_signal function to accept datetime object for the created_at argument #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rr404
approved these changes
Feb 8, 2024
Collaborator
rr404
left a comment
There was a problem hiding this comment.
LGTM
What do you think @julienloizelet
Collaborator
|
It works great. Thanks @TheophileDiot |
julienloizelet
pushed a commit
to julienloizelet/crowdsec-python-capi-sdk
that referenced
this pull request
Mar 14, 2024
… for the created_at argument (crowdsecurity#16)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the
create_signalfunction to accept a datetime object for thecreated_atargument. Previously, the function only accepted a string. With this change, users can provide datetime objects directly, enhancing flexibility and convenience.Changes Made
Modified Files
create_signalfunction to accept datetime objects for thecreated_atargument, expanding its usability and flexibility.