Skip to content

api: bump golang module to github.com/crossplane/crossplane-runtime/v2#859

Merged
jbw976 merged 2 commits intocrossplane:mainfrom
jbw976:mod-v2
Jul 30, 2025
Merged

api: bump golang module to github.com/crossplane/crossplane-runtime/v2#859
jbw976 merged 2 commits intocrossplane:mainfrom
jbw976:mod-v2

Conversation

@jbw976
Copy link
Copy Markdown
Member

@jbw976 jbw976 commented Jul 30, 2025

Description of your changes

Similar to crossplane/crossplane#6667, this PR bumps the go module name for this repo to github.com/crossplane/crossplane-runtime/v2 in preparation for the v2 release.

Part of crossplane/crossplane#6656

NOTE: after this is merged, when folks bump their imports of this repo, they will also need to update all of their import statements, similar to what is seen in this PR.

I have:

Need help with this checklist? See the cheat sheet.

Signed-off-by: Jared Watts <jbw976@gmail.com>
@jbw976 jbw976 requested a review from a team as a code owner July 30, 2025 17:40
@jbw976 jbw976 requested a review from phisco July 30, 2025 17:40
Copy link
Copy Markdown
Member

@turkenh turkenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

This updates our protobuf breaking changes detection to be aligned
(but a bit more strict to catch breaking changes to JSON encoding)
with what is done in core crossplane.

See crossplane/crossplane@ed343d1
for more details.

Signed-off-by: Jared Watts <jbw976@gmail.com>
@jbw976
Copy link
Copy Markdown
Member Author

jbw976 commented Jul 30, 2025

Note that protobuf-schemas check failed the first time. I have since added a commit to lower the breaking change detection level (from FILE to WIRE_JSON) to be more aligned with what is done in core crossplane, but a little more strict than that, given what we saw in crossplane/function-sdk-go#219 (comment).

cd03cdf

edit: great, now protobuf-schemas is passing 🙏

@jbw976 jbw976 merged commit 7de4de7 into crossplane:main Jul 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants