Bump crossplane go module to v2, bump crossplane-runtime imports to v2#6667
Bump crossplane go module to v2, bump crossplane-runtime imports to v2#6667jbw976 merged 4 commits intocrossplane:mainfrom
Conversation
| ARG GOARCH=${TARGETARCH} | ||
| ARG GOOS=${TARGETOS} | ||
| ARG GOFLAGS="\"-ldflags=-s -w -X=github.com/crossplane/crossplane/internal/version.version=${CROSSPLANE_VERSION}\"" | ||
| ARG GOFLAGS="\"-ldflags=-s -w -X=github.com/crossplane/crossplane/v2/internal/version.version=${CROSSPLANE_VERSION}\"" |
There was a problem hiding this comment.
almost missed this one! only noticed it when earthly +hack --SIMULATE_CROSSPLANE_VERSION=v2.0.0 wasn't bringing up a crossplane that actually had a version 😇
apis/apiextensions/v1/conversion.go
Outdated
| // ConvertSecretReference 'converts' a SecretReference by producing a deepcopy. | ||
| // This is necessary because goverter panics on type aliases (SecretReference is | ||
| // a type alias for common.SecretReference). | ||
| func ConvertSecretReference(in *xpv1.SecretReference) *xpv1.SecretReference { |
There was a problem hiding this comment.
This function was added because of the new type alias for SecretReference that was added in crossplane/crossplane-runtime@c056ae9#diff-0d8ebf4c1879297c0b02781d58ee25833e3e21e993939eda922e3ef49a7e417cR64.
Another way to handle this could be to change our usage of v1.SecretReference to common.SecretReference, but this converter approach could be more scoped. What do you think @turkenh?
There was a problem hiding this comment.
nevermind, @n3wscott figured out that bumping goverter to v1.9.1 fixes this panic and removes the need for the custom converter. it's gone now! 👋
|
@turkenh I have added more commits to bump |
8e199e3 to
562fe5b
Compare
Signed-off-by: Jared Watts <jbw976@gmail.com>
Signed-off-by: Jared Watts <jbw976@gmail.com>
…rossplane/crossplane-runtime/v2 Signed-off-by: Jared Watts <jbw976@gmail.com>
Signed-off-by: Jared Watts <jbw976@gmail.com>
|
Hooray, fuzz testing is fixed now from crossplane/crossplane-runtime#860 and 2a180eb 🎉 Both e2e test failures are If @turkenh is good with the |
Description of your changes
This PR bumps the module name to
github.com/crossplane/crossplane/v2in preparation for the v2.0 release, as well as picks up the latestcrossplane-runtimeand updates all its import paths togithub.com/crossplane/crossplane-runtime/v2.Part of #6656
I've tested this with a full build and
earthly +hack --SIMULATE_CROSSPLANE_VERSION=v2.0.0, then installing existing providers and functions via the demo scenarios in https://github.com/jbw976/demo-xp-layers and ensuring they still completely work. Everything looked fine 🙌NOTE: after this is merged, when folks bump their imports of this repo, they will also need to update all of their import statements, similar to what is seen in this PR.
I have:
earthly +reviewableto ensure this PR is ready for review.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Followed the API promotion workflow if this PR introduces, removes, or promotes an API.Need help with this checklist? See the cheat sheet.