machine instance: add machine instance claim type#942
Merged
negz merged 2 commits intocrossplane:masterfrom Oct 17, 2019
Merged
machine instance: add machine instance claim type#942negz merged 2 commits intocrossplane:masterfrom
negz merged 2 commits intocrossplane:masterfrom
Conversation
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Collaborator
|
|
negz
reviewed
Oct 17, 2019
negz
approved these changes
Oct 17, 2019
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Collaborator
|
|
Member
|
Really cool to see this get added @hasheddan!! 🙇 |
This was referenced Dec 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds claim kind that can be satisfied by machine instances such as VM's and bare metal servers as outline in #838. No portable classes or default class controllers are implemented due to their impending removal in #927.
Fixes #286
Checklist
I have:
make reviewableto ensure this PR is ready for review.clusterrole.yamlto include any new types.