Support Simple Resource Class Selection by negz · Pull Request #927 · crossplane/crossplane

negz · 2019-10-10T07:35:42Z

Description of your changes

This enables label based class matching per #926. Changes will also be required to crossplane-runtime, and all stacks.

Checklist

I have:

Run make reviewable to ensure this PR is ready for review.
Ensured this PR contains a neat, self documenting set of commits.
Updated any relevant documentation, examples, or release notes.
Updated the RBAC permissions in clusterrole.yaml to include any new types.

upbound-bot · 2019-10-10T07:40:19Z

hasheddan

A few comments about updates that I think will need to be made in crossplane-runtime and angryjet before these changes are made.

apis/cache/v1alpha1/rediscluster_types.go

upbound-bot · 2019-10-13T01:50:23Z

crossplane/crossplane#926 crossplane/crossplane#927 crossplane/crossplane-runtime#48 Updates angryjet to reflect the above changes. Signed-off-by: Nic Cope <negz@rk0n.org>

upbound-bot · 2019-10-18T23:45:42Z

upbound-bot · 2019-10-20T07:15:28Z

crossplane/crossplane#927 crossplane/crossplane-runtime#48 Signed-off-by: Nic Cope <negz@rk0n.org>

upbound-bot · 2019-10-21T22:07:09Z

crossplane/crossplane#927 crossplane/crossplane-runtime#48 Signed-off-by: Nic Cope <negz@rk0n.org>

upbound-bot · 2019-10-22T07:55:22Z

apis/kubernetes/v1alpha1/types.go

upbound-bot · 2019-10-22T21:20:37Z

upbound-bot · 2019-10-22T21:39:09Z

crossplane/crossplane#926 crossplane/crossplane#927 crossplane/crossplane-runtime#48 Updates angryjet to reflect the above changes. Signed-off-by: Nic Cope <negz@rk0n.org>

upbound-bot · 2019-10-23T05:23:24Z

hasheddan

LGTM!

crossplane/crossplane#927 crossplane/crossplane-runtime#48 Signed-off-by: Nic Cope <negz@rk0n.org>

upbound-bot · 2019-10-23T21:33:36Z

Signed-off-by: Nic Cope <negz@rk0n.org>

This also removes the default class controllers, and standardises the resource claim print columns, a few of which were not functional. Signed-off-by: Nic Cope <negz@rk0n.org>

This adds the new resource class selector, and also switches to our own connection secret kind. Signed-off-by: Nic Cope <negz@rk0n.org>

This was already a problem - we'd schedule workloads to a cluster that did not specify a connection secret (and was thus unusable by Crossplane). Now that connection secrets are pointer types this resulted in a nil pointer in the tests which highlighted the fact that we should handle this condition. Signed-off-by: Nic Cope <negz@rk0n.org>

Signed-off-by: Nic Cope <negz@rk0n.org>

Signed-off-by: Nic Cope <nicc@rk0n.org> Co-Authored-By: Daniel Mangum <31777345+hasheddan@users.noreply.github.com>

upbound-bot · 2019-10-23T22:09:24Z

hasheddan reviewed Oct 11, 2019

View reviewed changes

apis/cache/v1alpha1/rediscluster_types.go Outdated Show resolved Hide resolved

negz force-pushed the notsoclassy branch from f7e2263 to cec377c Compare October 13, 2019 01:46

negz mentioned this pull request Oct 17, 2019

Implement Simple Resource Class Selection for Azure crossplane-contrib/provider-azure#34

Closed

hasheddan mentioned this pull request Oct 17, 2019

machine instance: add machine instance claim type #942

Merged

4 tasks

negz mentioned this pull request Oct 17, 2019

Support simple resource class selection crossplane/crossplane-tools#7

Merged

2 tasks

negz force-pushed the notsoclassy branch 2 times, most recently from 14372e8 to 3af5221 Compare October 18, 2019 23:41

negz force-pushed the notsoclassy branch from 3af5221 to 5fa95f2 Compare October 20, 2019 07:03

negz force-pushed the notsoclassy branch from 5fa95f2 to c0c7a62 Compare October 20, 2019 07:35

negz added a commit to negz/provider-azure that referenced this pull request Oct 21, 2019

DO NOT MERGE: Use my crossplane and runtime branches

e81c325

crossplane/crossplane#927 crossplane/crossplane-runtime#48 Signed-off-by: Nic Cope <negz@rk0n.org>

negz added a commit to negz/provider-azure that referenced this pull request Oct 21, 2019

DO NOT MERGE: Use my crossplane and runtime branches

0c7a976

crossplane/crossplane#927 crossplane/crossplane-runtime#48 Signed-off-by: Nic Cope <negz@rk0n.org>

negz added a commit to negz/provider-azure that referenced this pull request Oct 21, 2019

DO NOT MERGE: Use my crossplane and runtime branches

be96a5b

crossplane/crossplane#927 crossplane/crossplane-runtime#48 Signed-off-by: Nic Cope <negz@rk0n.org>

negz mentioned this pull request Oct 21, 2019

Simple Resource Class Selection #952

Closed

11 tasks

negz added a commit to negz/provider-azure that referenced this pull request Oct 21, 2019

DO NOT MERGE: Use my crossplane and runtime branches

640d976

crossplane/crossplane#927 crossplane/crossplane-runtime#48 Signed-off-by: Nic Cope <negz@rk0n.org>

negz force-pushed the notsoclassy branch from c0c7a62 to e90d4be Compare October 21, 2019 22:02

negz marked this pull request as ready for review October 21, 2019 22:04

negz added a commit to negz/provider-azure that referenced this pull request Oct 21, 2019

DO NOT MERGE: Use my crossplane and runtime branches

fc96a79

crossplane/crossplane#927 crossplane/crossplane-runtime#48 Signed-off-by: Nic Cope <negz@rk0n.org>

negz changed the title ~~Remove support for portable resource classes and resource claim parameters~~ Support Simple Resource Class Selection Oct 22, 2019

negz added a commit to negz/provider-azure that referenced this pull request Oct 22, 2019

DO NOT MERGE: Use my crossplane and runtime branches

5f4c46b

crossplane/crossplane#927 crossplane/crossplane-runtime#48 Signed-off-by: Nic Cope <negz@rk0n.org>

This was referenced Oct 22, 2019

Implement Simple Resource Class Selection for GCP crossplane-contrib/provider-gcp#57

Closed

Implement Simple Resource Class Selection for AWS crossplane-contrib/provider-aws#41

Closed

negz force-pushed the notsoclassy branch from e90d4be to e9e873b Compare October 22, 2019 07:50

hasheddan suggested changes Oct 22, 2019

View reviewed changes

apis/kubernetes/v1alpha1/types.go Outdated Show resolved Hide resolved

negz force-pushed the notsoclassy branch from e4dfc1f to b3bbbc8 Compare October 22, 2019 21:34

negz force-pushed the notsoclassy branch from b3bbbc8 to b6b2b20 Compare October 23, 2019 05:16

negz requested a review from hasheddan October 23, 2019 05:18

hasheddan approved these changes Oct 23, 2019

View reviewed changes

negz added a commit to negz/provider-azure that referenced this pull request Oct 23, 2019

DO NOT MERGE: Use my crossplane and runtime branches

2d5c3c7

crossplane/crossplane#927 crossplane/crossplane-runtime#48 Signed-off-by: Nic Cope <negz@rk0n.org>

hasheddan mentioned this pull request Oct 23, 2019

docs: stack-rook stacks guide #964

Merged

4 tasks

displague mentioned this pull request Oct 23, 2019

Cluster scoped cluster stacks #959

Merged

4 tasks

negz force-pushed the notsoclassy branch from b6b2b20 to e11bfe3 Compare October 23, 2019 21:28

negz added a commit to negz/provider-azure that referenced this pull request Oct 23, 2019

DO NOT MERGE: Use my crossplane and runtime branches

bebdaeb

crossplane/crossplane#927 crossplane/crossplane-runtime#48 Signed-off-by: Nic Cope <negz@rk0n.org>

negz and others added 7 commits October 23, 2019 15:00

Bump crossplane-runtime dependency for simple resource class selection

0e4adac

Signed-off-by: Nic Cope <negz@rk0n.org>

Remove some redundant error checks

9a712e6

Signed-off-by: Nic Cope <negz@rk0n.org>

Remove support for portable classes

9caf45d

This also removes the default class controllers, and standardises the resource claim print columns, a few of which were not functional. Signed-off-by: Nic Cope <negz@rk0n.org>

Update generated claim methods

3ca49ef

This adds the new resource class selector, and also switches to our own connection secret kind. Signed-off-by: Nic Cope <negz@rk0n.org>

Make the Kubernetes Provider cluster scoped

8a79ce8

Signed-off-by: Nic Cope <negz@rk0n.org>

Use SecretReference for Kubernetes Provider

d62132d

Signed-off-by: Nic Cope <nicc@rk0n.org> Co-Authored-By: Daniel Mangum <31777345+hasheddan@users.noreply.github.com>

negz force-pushed the notsoclassy branch from e11bfe3 to d62132d Compare October 23, 2019 22:05

negz merged commit 518648b into crossplane:master Oct 23, 2019

negz deleted the notsoclassy branch October 23, 2019 22:13

Conversation

negz commented Oct 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of your changes

Checklist

Uh oh!

upbound-bot commented Oct 10, 2019

Uh oh!

hasheddan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

upbound-bot commented Oct 13, 2019

Uh oh!

upbound-bot commented Oct 18, 2019

Uh oh!

upbound-bot commented Oct 20, 2019

Uh oh!

upbound-bot commented Oct 21, 2019

Uh oh!

upbound-bot commented Oct 22, 2019

Uh oh!

Uh oh!

upbound-bot commented Oct 22, 2019

Uh oh!

upbound-bot commented Oct 22, 2019

Uh oh!

upbound-bot commented Oct 23, 2019

Uh oh!

hasheddan left a comment

Choose a reason for hiding this comment

Uh oh!

upbound-bot commented Oct 23, 2019

Uh oh!

upbound-bot commented Oct 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

negz commented Oct 10, 2019 •

edited

Loading