Skip to content

[release-1.35] Use compact logging only for List* RPCs#9953

Open
openshift-cherrypick-robot wants to merge 1 commit into
cri-o:release-1.35from
openshift-cherrypick-robot:cherry-pick-9951-to-release-1.35
Open

[release-1.35] Use compact logging only for List* RPCs#9953
openshift-cherrypick-robot wants to merge 1 commit into
cri-o:release-1.35from
openshift-cherrypick-robot:cherry-pick-9951-to-release-1.35

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented May 12, 2026

Copy link
Copy Markdown

This is an automated cherry-pick of #9951

/assign bitoku

Reduced the verbosity of debug logs for List* RPC calls to improve performance

@fmuyassarov
use compact logging only for List* RPCs
e423226 
List* RPCs can return large payloads that, when formatted with %+v,
produce large  protobuf text log messages causing gRPC deadline
exceeded errors (see issue cri-o#9894).

Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@est.tech>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 12, 2026
Merged
@openshift-ci openshift-ci Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 12, 2026
@coderabbitai

coderabbitai Bot commented May 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cb290354-060e-4e7d-a5cc-8e7c47e46873

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from QiWang19 and klihub May 12, 2026 18:31
@openshift-ci

openshift-ci Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign kolyshkin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.56%. Comparing base (5a749ba) to head (e423226).

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.35    #9953      +/-   ##
================================================
- Coverage         67.81%   64.56%   -3.25%     
================================================
  Files               213      213              
  Lines             29448    29457       +9     
================================================
- Hits              19970    19019     -951     
- Misses             7791     8745     +954     
- Partials           1687     1693       +6
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bitoku

bitoku commented May 15, 2026

Copy link
Copy Markdown
Contributor

/lgtm
@cri-o/cri-o-maintainers PTAL

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@bitoku bitoku

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openshift-cherrypick-robot @bitoku @fmuyassarov