Skip to content

[release-1.36] Use compact logging only for List* RPCs#9951

Merged
openshift-merge-bot[bot] merged 1 commit into
cri-o:release-1.36from
openshift-cherrypick-robot:cherry-pick-9919-to-release-1.36
May 12, 2026
Merged

[release-1.36] Use compact logging only for List* RPCs#9951
openshift-merge-bot[bot] merged 1 commit into
cri-o:release-1.36from
openshift-cherrypick-robot:cherry-pick-9919-to-release-1.36

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented May 12, 2026

Copy link
Copy Markdown

This is an automated cherry-pick of #9919

/assign bitoku

Reduced the verbosity of debug logs for List* RPC calls to improve performance

@fmuyassarov
use compact logging only for List* RPCs
4c5c0f4 
List* RPCs can return large payloads that, when formatted with %+v,
produce large  protobuf text log messages causing gRPC deadline
exceeded errors (see issue cri-o#9894).

Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@est.tech>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 12, 2026
Merged
@openshift-ci openshift-ci Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 12, 2026
@coderabbitai

coderabbitai Bot commented May 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3fba9558-f563-4716-a68b-c5b5f6c1f22b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from QiWang19 and bitoku May 12, 2026 03:53
@bitoku

bitoku commented May 12, 2026

Copy link
Copy Markdown
Contributor

/cherry-pick release-1.35

@openshift-cherrypick-robot

openshift-cherrypick-robot commented May 12, 2026

Copy link
Copy Markdown
Author

@bitoku: once the present PR merges, I will cherry-pick it on top of release-1.35 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bitoku

bitoku commented May 12, 2026

Copy link
Copy Markdown
Contributor

/lgtm
@cri-o/cri-o-maintainers PTAL

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2026
@codecov

codecov Bot commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.66%. Comparing base (d0114b1) to head (4c5c0f4).

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.36    #9951      +/-   ##
================================================
+ Coverage         64.59%   64.66%   +0.07%     
================================================
  Files               215      215              
  Lines             29674    29683       +9     
================================================
+ Hits              19168    19195      +27     
+ Misses             8805     8791      -14     
+ Partials           1701     1697       -4
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haircommander

haircommander commented May 12, 2026

Copy link
Copy Markdown
Member

/approve

@openshift-ci

openshift-ci Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 60693ed into cri-o:release-1.36 May 12, 2026
48 of 49 checks passed
@openshift-cherrypick-robot

openshift-cherrypick-robot commented May 12, 2026

Copy link
Copy Markdown
Author

@bitoku: new pull request created: #9953

Details

In response to this:

/cherry-pick release-1.35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 12, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@bitoku bitoku Awaiting requested review from bitoku

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@bitoku bitoku

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @bitoku @haircommander @fmuyassarov