OCPBUGS-78585: [1.35] Return image ID from PullImage instead of repo digest by haircommander · Pull Request #9826 · cri-o/cri-o

haircommander · 2026-03-17T16:18:16Z

Resolve the pulled image reference to a storage image ID in the server layer (server/image_pull.go) rather than changing the storage layer's PullImage return type. This keeps the storage layer's contract unchanged while the server resolves references to IDs via ImageStatusByName, with a fallback to the artifact store for OCI artifacts.

What type of PR is this?

cherry-pick of #9728
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

PullImage now returns the image ID directly, ensuring compatibility with Kubernetes credential verification for image pulls.

coderabbitai · 2026-03-17T16:19:20Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d8da58de-16a4-4278-8573-ba9573f7a4bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.

Add a .trivyignore file to your project to customize which findings Trivy reports.

haircommander · 2026-03-17T16:23:36Z

/jira refresh

openshift-ci-robot · 2026-03-17T16:23:40Z

@haircommander: This pull request references Jira Issue OCPBUGS-78585, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-78585 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Resolve the pulled image reference to a storage image ID in the server layer (server/image_pull.go) rather than changing the storage layer's PullImage return type. This keeps the storage layer's contract unchanged while the server resolves references to IDs via ImageStatusByName, with a fallback to the artifact store for OCI artifacts.

What type of PR is this?

cherry-pick of #9728
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?
PullImage now returns the image ID directly, ensuring compatibility with Kubernetes credential verification for image pulls.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-17T16:23:43Z

@haircommander: This pull request references Jira Issue OCPBUGS-78585, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-78585 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

codecov · 2026-03-17T19:53:04Z

Codecov Report

❌ Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.65%. Comparing base (c22ce9f) to head (979de4b).
⚠️ Report is 2 commits behind head on release-1.35.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-1.35    #9826      +/-   ##
================================================
+ Coverage         67.49%   67.65%   +0.15%     
================================================
  Files               211      211              
  Lines             29253    29264      +11     
================================================
+ Hits              19745    19798      +53     
+ Misses             7826     7781      -45     
- Partials           1682     1685       +3

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

saschagrunert · 2026-03-19T13:23:46Z

@haircommander please rebase

Resolve the pulled image reference to a storage image ID in the server layer (server/image_pull.go) rather than changing the storage layer's PullImage return type. This keeps the storage layer's contract unchanged while the server resolves references to IDs via ImageStatusByName, with a fallback to the artifact store for OCI artifacts. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>

haircommander · 2026-03-23T15:40:12Z

this is ready!

openshift-ci · 2026-03-23T15:41:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

saschagrunert · 2026-03-23T15:41:11Z

/jira refresh

openshift-ci-robot · 2026-03-23T15:41:16Z

@saschagrunert: This pull request references Jira Issue OCPBUGS-78585, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-78585 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-23T15:46:16Z

@haircommander: Jira Issue OCPBUGS-78585: All pull requests linked via external trackers have merged:

cri-o/cri-o#9826

Jira Issue OCPBUGS-78585 has been moved to the MODIFIED state.

Details

In response to this:

Resolve the pulled image reference to a storage image ID in the server layer (server/image_pull.go) rather than changing the storage layer's PullImage return type. This keeps the storage layer's contract unchanged while the server resolves references to IDs via ImageStatusByName, with a fallback to the artifact store for OCI artifacts.

What type of PR is this?

cherry-pick of #9728
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?
PullImage now returns the image ID directly, ensuring compatibility with Kubernetes credential verification for image pulls.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

haircommander requested a review from mrunalp as a code owner March 17, 2026 16:18

openshift-ci Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Mar 17, 2026

openshift-ci Bot requested review from hasan4791 and littlejawa March 17, 2026 16:18

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2026

haircommander changed the title ~~[1.35] Return image ID from PullImage instead of repo digest~~ OCPBUGS-78585: [1.35] Return image ID from PullImage instead of repo digest Mar 17, 2026

openshift-ci-robot added the jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. label Mar 17, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 17, 2026

haircommander force-pushed the fix-pullimage-return-imageid-1.35 branch from fa5538f to 979de4b Compare March 22, 2026 10:12

saschagrunert approved these changes Mar 23, 2026

View reviewed changes

openshift-ci Bot assigned saschagrunert Mar 23, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2026

openshift-merge-bot Bot merged commit 1715a5b into cri-o:release-1.35 Mar 23, 2026
50 of 51 checks passed

Conversation

haircommander commented Mar 17, 2026

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

coderabbitai Bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

haircommander commented Mar 17, 2026

Uh oh!

openshift-ci-robot commented Mar 17, 2026

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

openshift-ci-robot commented Mar 17, 2026

Uh oh!

codecov Bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

saschagrunert commented Mar 19, 2026

Uh oh!

haircommander commented Mar 23, 2026

Uh oh!

openshift-ci Bot commented Mar 23, 2026

Uh oh!

saschagrunert commented Mar 23, 2026

Uh oh!

openshift-ci-robot commented Mar 23, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 23, 2026

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Mar 17, 2026 •

edited

Loading

codecov Bot commented Mar 17, 2026 •

edited

Loading