Skip to content

feat: crypto compare api integration skill set #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hyacinthus merged 13 commits into from
Feb 13, 2025
Merged

feat: crypto compare api integration skill set #172

hyacinthus merged 13 commits into from
Feb 13, 2025

Conversation

@apeoverflow
Copy link
Contributor

@apeoverflow apeoverflow commented Feb 5, 2025

Description

Please include a summary of the changes and the related issue.

Type of Change

  • Bugfix
  • New Feature
  • Improvement
  • Documentation Update

Checklist

  • I have read the contributing guidelines.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Related Issue

Add CryptoCompare Skills Module

Description

This PR introduces a new CryptoCompare skills module that integrates with the CryptoCompare API. The module expands our platform’s capabilities by providing tools to fetch various cryptocurrency-related data, including:

  • News Articles: Retrieve the latest news for specific tokens, with an option to use a custom timestamp for historical queries.
  • Price Data: Fetch real-time price information for a base cryptocurrency against a list of target currencies.
  • Trading Signals: Get advanced trading signals and market indicators for a given cryptocurrency.
  • Top Market Cap: Retrieve the top cryptocurrencies ranked by market capitalization.
  • Top Exchanges: Fetch information on the top exchanges for specific trading pairs.
  • Top Volume: Identify the most actively traded cryptocurrencies by volume.

The module is structured similarly to our existing Twitter and Moralis skills modules to ensure consistency across our codebase.

Changes

  • New Directory and Files:

    • Created a new folder: skills/cryptocompare/
    • Added the following files:
      • __init__.py: Contains the factory function get_cryptocompare_skill which maps skill names to their respective tool classes.
      • api.py: Houses API configuration (base URL, API key), shared input schemas, API functions, and prompt strings.
      • base.py: Implements the CryptoCompareBaseTool with common functionalities such as rate limiting.
      • Individual tool files:
        • fetch_news.py
        • fetch_price.py
        • fetch_trading_signals.py
        • fetch_top_market_cap.py
        • fetch_top_exchanges.py
        • fetch_top_volume.py

  • API Integration:

    • All API calls use the CRYPTO_COMPARE_API_KEY environment variable for authentication.
    • The module leverages synchronous API calls wrapped in asynchronous functions with proper error handling and rate limiting.

Motivation

Integrating CryptoCompare data will allow our platform to source robust and comprehensive cryptocurrency insights, enhancing our analytical capabilities and providing richer data to our users.

Testing

  • Manual tests have confirmed that each tool successfully communicates with the CryptoCompare API.
  • Verified that the rate limiting mechanism is working as expected to prevent API abuse.
  • Tested data retrieval for news, price, trading signals, top market cap, top exchanges, and top volume.

Closes #171

@hyacinthus
Copy link
Collaborator

hyacinthus commented Feb 5, 2025

Thank you for contributing the code; it looks great. I’m testing your code locally and will provide you with feedback later. Thank you.

@crestalnetwork crestalnetwork deleted a comment from Cngok88 Feb 7, 2025
@kikysykes
Copy link

kikysykes commented Feb 7, 2025

I just started hahahaha

@kikysykes
Copy link

kikysykes commented Feb 7, 2025

Someone help me for my life.. I need some money

hyacinthus
hyacinthus requested changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@hyacinthus hyacinthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should pass the key in get_cryptocompare_skill instead of using an environment variable to get it.

Our generic skill loading mode is not fully finalized yet. After addressing the above issues, this PR should be fine as skills. We will make a few change later to allow it to be configurable and loaded by agent.

@apeoverflow
Copy link
Contributor Author

apeoverflow commented Feb 8, 2025

Hey @hyacinthus ,

Made the changes you advised.

FYI: doing this PR for the EthGlobal Hackathon

@hyacinthus
Copy link
Collaborator

hyacinthus commented Feb 9, 2025

Hey @hyacinthus ,

Made the changes you advised.

FYI: doing this PR for the EthGlobal Hackathon

Thanks, I'll test them tomorrow.

hyacinthus
hyacinthus requested changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@hyacinthus hyacinthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test still cannot pass; please address the outstanding issues. Thank you.

@apeoverflow
Copy link
Contributor Author

apeoverflow commented Feb 12, 2025

Hi, The above issues have been resolved. Can you check the skill again. Thank you.

@hyacinthus hyacinthus merged commit c63af41 into crestalnetwork:main Feb 13, 2025
1 check failed
hyacinthus added a commit that referenced this pull request Jul 10, 2025
@hyacinthus
Merge pull request #172 from 0xkieranwilliams/feat/skills-cryptocompare
c10471e 
feat: crypto compare api integration skill set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyacinthus hyacinthus hyacinthus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feat: Crypto Compare API integration Skill

4 participants

@apeoverflow @hyacinthus @kikysykes @sethupavan12