Merged
Conversation
mfussenegger
commented
Oct 23, 2018
|
|
||
| @Override | ||
| public Version getMinimalSupportedVersion() { | ||
| return Version.V_6_0_0; |
Member
Author
There was a problem hiding this comment.
We probably have to think about how we make use of this in the future. For now I chose 6.0.0 everywhere. We shipped CrateDB 3.0 with ES 6.1 and it's not supported to do rolling upgrades from earlier versions to it. So this should be safe.
BaurzhanSakhariev
added a commit
that referenced
this pull request
Nov 21, 2025
…onException Catching EsRejectedExecutionException won't catch RejectedExecutionException However, this is not a bug fix as we don't throw RejectedExecutionException anywhere and use executors that throw EsRejectedExecutionException See also elastic/elasticsearch#29075, it made catching only RejectedExecutionException sufficient, and we inherited it and cleaned up our EsRejectedExecutionException usages in #7806. This change is a follow-up #7806
BaurzhanSakhariev
added a commit
that referenced
this pull request
Nov 21, 2025
…onException Catching EsRejectedExecutionException won't catch RejectedExecutionException However, this is not a bug fix as we don't throw RejectedExecutionException anywhere and use executors that throw EsRejectedExecutionException See also elastic/elasticsearch#29075, it made catching only RejectedExecutionException sufficient, and we inherited it and cleaned up our EsRejectedExecutionException usages in #7806. This change is a follow-up #7806
mergify bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
…onException Catching EsRejectedExecutionException won't catch RejectedExecutionException However, this is not a bug fix as we don't throw RejectedExecutionException anywhere and use executors that throw EsRejectedExecutionException See also elastic/elasticsearch#29075, it made catching only RejectedExecutionException sufficient, and we inherited it and cleaned up our EsRejectedExecutionException usages in #7806. This change is a follow-up #7806
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES.txt