Skip to content

WIP: write oid in the source#14629

Closed
BaurzhanSakhariev wants to merge 1 commit intooid-in-sourcefrom
b/write-oid
Closed

WIP: write oid in the source#14629
BaurzhanSakhariev wants to merge 1 commit intooid-in-sourcefrom
b/write-oid

Conversation

@BaurzhanSakhariev
Copy link
Contributor

@BaurzhanSakhariev BaurzhanSakhariev commented Aug 30, 2023

Next step after #14617.

Early draft

TODO:

  • use oid (already assigned in mapping) instead of colname
  • (reads) Change LuceneReferenceResolver/Lucene reading logic to access data by oid instead of column name
  • (reads) Need to update query building to use oid instead of column name
  • Primary key lookup? (check PKLookupOperation)
  • (indexing) Change mapper implementations to use oid as field name
  • (indexing) Change source generation to use oid as field name
  • Change _raw lookup to rewrite oid to name and don’t' include dropped columns
  • select _raw must hide dropped columns

@BaurzhanSakhariev BaurzhanSakhariev mentioned this pull request Aug 30, 2023
2 tasks
@BaurzhanSakhariev
Copy link
Contributor Author

BaurzhanSakhariev commented Aug 30, 2023

Actually should use Version dependant Function<Ref, String> sourceKeyWriter to be either leafName or oid.toString

@BaurzhanSakhariev BaurzhanSakhariev deleted the branch oid-in-source August 31, 2023 07:36
@BaurzhanSakhariev BaurzhanSakhariev deleted the b/write-oid branch August 31, 2023 07:43
matriv added a commit that referenced this pull request Oct 21, 2025
Apply changes made between 10.2.2 and 10.3.1 versions:
```
$ g log --oneline releases/lucene/10.2.2..releases/lucene/10.3.1 lucene/core/src/java/org/apache/lucene/codecs/lucene90/{Lucene90DocValuesProducer.java,Lucene90DocValuesConsumer.java,Lucene90DocValuesFormat.java}
d176a42b659 Implement IndexedDISI#docIDRunEnd (#14753)
223d7a41e3c [10.x] Change uses of withReadAdvice to use hints instead (#14629) (#14510)
bb3167e57c6 Impl intoBitset for IndexedDISI and Docvalues (#14529)
```

Relevant PRs:
apache/lucene#14753
apache/lucene#14510
apache/lucene#14529

Follows: #18545
matriv added a commit that referenced this pull request Oct 21, 2025
Apply changes made between 10.2.2 and 10.3.1 versions:
```
$ g log --oneline releases/lucene/10.2.2..releases/lucene/10.3.1 lucene/core/src/java/org/apache/lucene/codecs/lucene90/{Lucene90DocValuesProducer.java,Lucene90DocValuesConsumer.java,Lucene90DocValuesFormat.java}
d176a42b659 Implement IndexedDISI#docIDRunEnd (#14753)
223d7a41e3c [10.x] Change uses of withReadAdvice to use hints instead (#14629) (#14510)
bb3167e57c6 Impl intoBitset for IndexedDISI and Docvalues (#14529)
```

Relevant PRs:
apache/lucene#14753
apache/lucene#14510
apache/lucene#14529

Follows: #18545
matriv added a commit that referenced this pull request Oct 21, 2025
Apply changes made between 10.2.2 and 10.3.1 versions:
```
$ g log --oneline releases/lucene/10.2.2..releases/lucene/10.3.1 lucene/core/src/java/org/apache/lucene/codecs/lucene90/{Lucene90DocValuesProducer.java,Lucene90DocValuesConsumer.java,Lucene90DocValuesFormat.java}
d176a42b659 Implement IndexedDISI#docIDRunEnd (#14753)
223d7a41e3c [10.x] Change uses of withReadAdvice to use hints instead (#14629) (#14510)
bb3167e57c6 Impl intoBitset for IndexedDISI and Docvalues (#14529)
```

Relevant PRs:
apache/lucene#14753
apache/lucene#14510
apache/lucene#14529

Follows: #18545
matriv added a commit that referenced this pull request Oct 21, 2025
Apply changes made between 10.2.2 and 10.3.1 versions:
```
$ g log --oneline releases/lucene/10.2.2..releases/lucene/10.3.1 lucene/core/src/java/org/apache/lucene/codecs/lucene90/{Lucene90DocValuesProducer.java,Lucene90DocValuesConsumer.java,Lucene90DocValuesFormat.java}
d176a42b659 Implement IndexedDISI#docIDRunEnd (#14753)
223d7a41e3c [10.x] Change uses of withReadAdvice to use hints instead (#14629) (#14510)
bb3167e57c6 Impl intoBitset for IndexedDISI and Docvalues (#14529)
```

Relevant PRs:
apache/lucene#14753
apache/lucene#14510
apache/lucene#14529

Follows: #18545
matriv added a commit that referenced this pull request Oct 21, 2025
Apply changes made between 10.2.2 and 10.3.1 versions:
```
$ g log --oneline releases/lucene/10.2.2..releases/lucene/10.3.1 lucene/core/src/java/org/apache/lucene/codecs/lucene90/{Lucene90DocValuesProducer.java,Lucene90DocValuesConsumer.java,Lucene90DocValuesFormat.java}
d176a42b659 Implement IndexedDISI#docIDRunEnd (#14753)
223d7a41e3c [10.x] Change uses of withReadAdvice to use hints instead (#14629) (#14510)
bb3167e57c6 Impl intoBitset for IndexedDISI and Docvalues (#14529)
```

Relevant PRs:
apache/lucene#14753
apache/lucene#14510
apache/lucene#14529

Follows: #18545
mergify bot pushed a commit that referenced this pull request Oct 21, 2025
Apply changes made between 10.2.2 and 10.3.1 versions:
```
$ g log --oneline releases/lucene/10.2.2..releases/lucene/10.3.1 lucene/core/src/java/org/apache/lucene/codecs/lucene90/{Lucene90DocValuesProducer.java,Lucene90DocValuesConsumer.java,Lucene90DocValuesFormat.java}
d176a42b659 Implement IndexedDISI#docIDRunEnd (#14753)
223d7a41e3c [10.x] Change uses of withReadAdvice to use hints instead (#14629) (#14510)
bb3167e57c6 Impl intoBitset for IndexedDISI and Docvalues (#14529)
```

Relevant PRs:
apache/lucene#14753
apache/lucene#14510
apache/lucene#14529

Follows: #18545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant