Skip to content

#1577: All implementations of Iterable return true for is List<T> in CQL#1666

Merged
JPercival merged 2 commits intomasterfrom
fix-issue-1577-2
Jan 20, 2026
Merged

#1577: All implementations of Iterable return true for is List<T> in CQL#1666
JPercival merged 2 commits intomasterfrom
fix-issue-1577-2

Conversation

@antvaset
Copy link
Copy Markdown
Contributor

Closes #1661 (related to #1577 and #1641).

Currently, is List<T> in CQL returns true for Java lists. This should happen for all implementations of Iterable.

@github-actions
Copy link
Copy Markdown

Formatting check succeeded!

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.88%. Comparing base (0399fa1) to head (02e045d).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rg/opencds/cqf/cql/engine/execution/Environment.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1666      +/-   ##
============================================
- Coverage     65.88%   65.88%   -0.01%     
  Complexity     1645     1645              
============================================
  Files           477      477              
  Lines         27503    27505       +2     
  Branches       5470     5471       +1     
============================================
+ Hits          18120    18121       +1     
  Misses         7084     7084              
- Partials       2299     2300       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@JPercival JPercival merged commit 32bb364 into master Jan 20, 2026
8 of 9 checks passed
@JPercival JPercival deleted the fix-issue-1577-2 branch January 20, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

This fix should be reflected in "is" as well, yes?

2 participants