Conversation
…d as is when being cast to CQL lists.
|
Formatting check succeeded! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1641 +/- ##
============================================
+ Coverage 65.76% 65.78% +0.01%
Complexity 1646 1646
============================================
Files 472 472
Lines 27424 27426 +2
Branches 5457 5458 +1
============================================
+ Hits 18036 18042 +6
+ Misses 7089 7086 -3
+ Partials 2299 2298 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
raleigh-g-thompson
approved these changes
Nov 14, 2025
c-schuler
approved these changes
Nov 18, 2025
Contributor
c-schuler
left a comment
There was a problem hiding this comment.
The quality gate is not passing and it would be nice to see some of the specific examples given in the issues as part of the tests. However, the code looks good to me
raleigh-g-thompson
approved these changes
Nov 19, 2025
|
JPercival
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1577. Closes #1636. Closes #1569.
Currently, when runtime Java lists are cast to CQL's
List<T>types, they are returned as is. This should happen for all implementations ofIterable.This issue can be replicated using the VSCode extension and language server, which use the
FederatedDataProvider. In that retrieve provider, everything is correct and it returns anIterable(FluentIterable). In this fix, the As evaluator now handlesIterables correctly which are not necessarily Java lists.