review suggestions for moby#47239 #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move it to a separate function; while the intended purpose is for debugging, it does not have to be in the same function that fills the debug information. Also pass the daemon configuration that's already present, instead of fetching it separately. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- move the example-values per-field to prevent the example response getting out of sync with the actual struct. - add default values for each field (although these are configurable) - add some wording about these values being configurable, but not generally recommended to be changed. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Update the GoDoc of this struct with a description similar to what's used in the swagger. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This field was introduced in API 1.46, and should not be returned on older API versions. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
cpuguy83
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integration/container: TestContainerdContainerImageInfo: adjust API version
The "Containerd" field in /info was added in API 1.46
daemon: move filling ContainerdInfo to fillContainerdInfo
Move it to a separate function; while the intended purpose is
for debugging, it does not have to be in the same function
that fills the debug information.
Also pass the daemon configuration that's already present,
instead of fetching it separately.
api: swagger: move examples per-field, and update descriptions
getting out of sync with the actual struct.
generally recommended to be changed.
api/types/system: ContainerdNamespaces: update GoDoc
Update the GoDoc of this struct with a description similar to what's
used in the swagger.
api/server/router/system: hide Containerd field on API < 1.46
This field was introduced in API 1.46, and should not be returned on
older API versions.
docs/api: update version history