Add support for [[likely]], misc brace bugfixes, and drop support for Python 3.8#277
Merged
aaronliu0130 merged 6 commits intocpplint:developfrom Jul 1, 2024
Merged
Add support for [[likely]], misc brace bugfixes, and drop support for Python 3.8#277aaronliu0130 merged 6 commits intocpplint:developfrom
aaronliu0130 merged 6 commits intocpplint:developfrom
Conversation
A chromium sample has been updated to a version that uses C++17 stuff READMEs of samples have been clarified regarding licensing Two licenses have also been updated Skip CI because I amended a typo in the commit message
1. Fixes cpplint#212 2. else statements that have braces on both sides but have the second-to-last } on a separate line will no longer claim we need braces on both sides 3. Fix single-line if statements being yelled at to split their lines, something contradictory to the style guide 4. Fixes relevant tests, including adding the new "TestLintContains" and "TestLintNotContains" methods. (ik the latter may have a grammar error but who cares, this is consistent with the former's name) 5. Add a todo for "This exception does not apply to multi-keyword statements like if ... else or do ... while."
Needed to use the `:=` operator
...to our varname style guide. Was previously 534a142 but I forgot to pull from my own branch. Darn... Early-onset dementia? *knocks on wood*
aaronliu0130
approved these changes
Jul 1, 2024
Member
aaronliu0130
left a comment
There was a problem hiding this comment.
Tests already ran once in the last PR
tkruse
reviewed
Aug 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge request for #265