feat: add Brazilian Portuguese translations#1050
Merged
Merged
Conversation
Member
Author
|
@all-contributors add @crcpucmg as a contributor for translations. |
Contributor
|
I've put up a pull request to add @crcpucmg! 🎉 |
Contributor
|
I accepted the invitation. Thanks.
I will try to find a reviewer. In the meantime, I'll do another review,
just in case.
Em sáb., 12 de fev. de 2022 às 10:54, Yufan You ***@***.***>
escreveu:
… @crcpucmg <https://github.com/crcpucmg>, thanks for your contribution!
It would be better if you can invite someone else to review these
translations, or you can check them again. It would also be OK if you don't
feel like checking again. Tell me when you think this is ready to be merged.
I have invited you to the organization. After accepting the invitation,
you'll have write-access to this pull request. If you don't want to make
modifications via git/github, you can send me the modified translation file.
------------------------------
You can view, comment on, or merge this pull request online at:
#1050
Commit Summary
- 778d0ca
<778d0ca>
feat: add Brazilian Portuguese translations
- 44166d8
<44166d8>
feat: apply changes for pt_BR translations
File Changes
(7 files <https://github.com/cpeditor/cpeditor/pull/1050/files>)
- *M* CMakeLists.txt
<https://github.com/cpeditor/cpeditor/pull/1050/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a>
(1)
- *M* src/Core/Translator.cpp
<https://github.com/cpeditor/cpeditor/pull/1050/files#diff-d9f0add81ec2377b99c22e1f48d9b0e035bf7a5672de6961e5011030160636a8>
(12)
- *M* src/Settings/settings.json
<https://github.com/cpeditor/cpeditor/pull/1050/files#diff-af92da0553e653a655f4b3a4ca5ab1c39721541bf6473511a8daac95a3d21844>
(2)
- *M* tools/updateTranslation.bat
<https://github.com/cpeditor/cpeditor/pull/1050/files#diff-9e4bac869c2d17ff12be929b4b58b58edef39f78b8960272e6ea01c728162d9b>
(2)
- *M* tools/updateTranslation.sh
<https://github.com/cpeditor/cpeditor/pull/1050/files#diff-6ae7b64cf0a3c9995843e25294fd75653f596cfe884622041081d057a58dff6e>
(2)
- *A* translations/pt_BR.ts
<https://github.com/cpeditor/cpeditor/pull/1050/files#diff-e8c2fdb635bd0686eaa239deefc41a642e23c6c160444ce3d959af53145db9e0>
(3271)
- *M* translations/translations.qrc
<https://github.com/cpeditor/cpeditor/pull/1050/files#diff-4233401a9e85a25235756d3625491988bf9b6294605080284bb435698dc6c542>
(1)
Patch Links:
- https://github.com/cpeditor/cpeditor/pull/1050.patch
- https://github.com/cpeditor/cpeditor/pull/1050.diff
—
Reply to this email directly, view it on GitHub
<#1050>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRDNVCCXMJ6YY6MO5JLLM3U2ZQ7NANCNFSM5OG4JH2Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
Approving for fulfilling the merge criteria. Just in case crcpucmg cannot find a reviewer and we want to merge this PR. |
coder3101
approved these changes
Feb 13, 2022
swiftqwq
reviewed
Feb 16, 2022
Contributor
|
About "Hot Exit" and "Saída": it was the best choice at the time.
The word "exit" can have two uses: as a verb (leave/go out), or as a noun
(output/way out).
I chose ("saída" as a noun) would be better for (backing up and) leaving
the editor.
It could receive an adverb like "abruptly" or "unexpectedly", but I left it
without.
Em qua., 16 de fev. de 2022 às 07:12, Yiming Zhang ***@***.***>
escreveu:
… ***@***.**** commented on this pull request.
------------------------------
In translations/pt_BR.ts
<#1050 (comment)>:
> + <source>Hot Exit</source>
+ <translation>Saída</translation>
@crcpucmg <https://github.com/crcpucmg> Does "Saída" mean "Hot Exit" in
Portuguese?
https://www.collinsdictionary.com/dictionary/portuguese-english/saida
—
Reply to this email directly, view it on GitHub
<#1050 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRDNVGT3J5KLRYKX267Z73U3NZ7LANCNFSM5OG4JH2Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
@ouuan can we merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@crcpucmg, thanks for your contribution!
It would be better if you can invite someone else to review these translations, or you can check them again. It would also be OK if you don't feel like checking again. Tell me when you think this is ready to be merged.
I have invited you to the organization. After accepting the invitation, you'll have write-access to this pull request. If you don't want to make modifications via git/github, you can send me the modified translation file.