Active space: Implement ERI calculation using half-transformed integrals#3082
Merged
fstein93 merged 8 commits intocp2k:masterfrom Oct 31, 2023
Merged
Active space: Implement ERI calculation using half-transformed integrals#3082fstein93 merged 8 commits intocp2k:masterfrom
fstein93 merged 8 commits intocp2k:masterfrom
Conversation
Turning it off results into segfaults because not being implemented. Would also not run efficiently without it.
prepares application of code for active space code
Clusters communication steps
The option was available but not implemented. It allows to reduce the memory demands.
reduces communication costs but increases memory demands
MGraml
pushed a commit
to MGraml/cp2k
that referenced
this pull request
Nov 20, 2023
…als (cp2k#3082) This PR implements several options which have already been available in the input but were not implemented: half-transformed integral calculation algorithm: borrowed from the GPW-MP2 method. It is a much fast algorithm to calculate the integrals, especially if all orbitals are correlated. This implementation is 2-3 faster than the legacy FULL_GPW algorithm. store_wfn: this option enables the on-the-fly calculation the orbital functions on a grid. It increases the costs by 40 % in case of half-transformed integrals (no idea in case of the FULL_GPW method but probably much more expensive than the with storing the orbitals). It allows to reduce the memory footprint significantly, especially in case of molecular systems with their larger number of grid points subgroups: As in the WFC module, the calculation of integrals is possible in subgroups trading memory for reduced communication. I measured a threefold improvement. The new implementation is GPU accelerated as it relies on DBCSR and the grid code for the integration of the potential (untested). A bunch of new regression tests (QS/regtest-as-2, QS/regtest-as-3) This implementation works well with the GPW method but is inadequate if highly localised AOs are present (known issue of GPW). In these cases, a GAPW-like implementation would be advantageous but a matter of implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements several options which have already been available in the input but were not implemented:
This implementation works well with the GPW method but is inadequate if highly localised AOs are present (known issue of GPW). In these cases, a GAPW-like implementation would be advantageous but a matter of implementation.