Merged
Conversation
mkrack
added a commit
to mkrack/cp2k
that referenced
this pull request
Dec 8, 2022
Follow-up to cp2k#2438
mtaillefumier
pushed a commit
to mtaillefumier/cp2k
that referenced
this pull request
Dec 9, 2022
* Remove __MPI_VERSION flag * Fix typo * Fix compilation in serial mode and compilation of PT-Scotch * Fix toolchain
mtaillefumier
pushed a commit
to mtaillefumier/cp2k
that referenced
this pull request
Dec 9, 2022
Follow-up to cp2k#2438
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MPI-3.0-specification was published 10 years (!) ago. Thus, we may safely assume that all MPI implementations in use support the MPI-3.0-standard. (MPI-4.1 was released last year. Hints to "older" implementations of MPI in CP2K are ca. 7 years old.)
As a follow-up, we may switch from the Fortran 90 bindings to the Fortran 2008 bindings.
One should apply these changes to DBCSR, too.
PT-Scotch and PEXSI could be updated to a later version to drop the mp1-compatability-flag and stick completely to the MPI-3.0-standard.