Skip to content

Refactoring of basis set optimization code#2068

Merged
juerghutter merged 6 commits intomasterfrom
TDLRI
Apr 13, 2022
Merged

Refactoring of basis set optimization code#2068
juerghutter merged 6 commits intomasterfrom
TDLRI

Conversation

@juerghutter
Copy link
Contributor

No description provided.

@juerghutter juerghutter merged commit e97efa5 into master Apr 13, 2022
@hfp
Copy link
Member

hfp commented Apr 13, 2022

Maybe this is related? The input QS/regtest-gapw-2/C-levelshift.inp misses the error margin (CUDA Pascal Regtest). The input QS/regtest-optbas/opt-1.inp seems to fail (also CUDA Pascal Regtest), and the backtrace is (crash in mpi_allreduce @ mp_sum_l):

            6 mp_sum_l
            5 init_training_force_envs
            4 driver_optimization_para_low
            3 driver_para_opt_basis
            2 run_optimize_basis
            1 CP2K

mtaillefumier pushed a commit to mtaillefumier/cp2k that referenced this pull request Apr 14, 2022
* Basis optimization refactoring

* Refactoring of Optimize Basis code
remove dependence on qs_env/ADMM

* Formatting

* Remove dependence on ADMM env
Remove dependence on AUX_FIT basis

* Release unused data from qs_env

* Correctly initialize cell_traj (Herve Bulou: CP2K-16824)
Cloudac7 pushed a commit to Cloudac7/cp2k that referenced this pull request Apr 23, 2022
* Basis optimization refactoring

* Refactoring of Optimize Basis code
remove dependence on qs_env/ADMM

* Formatting

* Remove dependence on ADMM env
Remove dependence on AUX_FIT basis

* Release unused data from qs_env

* Correctly initialize cell_traj (Herve Bulou: CP2K-16824)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants