Update kamaji version #633

lllamnyp · 2025-02-18T07:52:53Z

Stripped port number from KamajiControlPlane hostname due to Kamaji infinity loop for certificate update. clastix/kamaji#679
Bumped versions for kamaji and dependent charts

Summary by CodeRabbit

New Features
- Introduced a migration process that upgrades system configurations to the latest release.
- Added a new script for migrating from version 9 to version 10 of the Kubernetes application.
Chores
- Upgraded the underlying application version and improved the patch application method.
- Updated release configuration and version mappings for improved consistency.
- Revised the installation process with an updated version variable.
Refactor
- Modified network routing settings to remove fixed port assignments from host definitions.

* Stripped port number from KamajiControlPlane hostname due to clastix/kamaji#679 * Bumped versions for kamaji and dependent charts

coderabbitai · 2025-02-18T07:53:01Z

Walkthrough

This pull request updates several configuration and deployment files. It removes a hardcoded port from the hostname in the ingress section, upgrades version numbers in the Kamaji Dockerfile, Kubernetes Chart, installer script, and version mapping, and corrects migration comments. A new migration script has also been added to update application configurations via Kubernetes commands. These changes adjust versioning and patching approaches without altering core functionality.

Changes

File(s)	Change Summary
`packages/apps/kubernetes/templates/cluster.yaml`	Removed hardcoded port (`:443`) from the hostname in the ingress configuration of the KamajiControlPlane resource.
`packages/system/kamaji/images/kamaji/Dockerfile`	Upgraded Kamaji version from `edge-24.9.2` to `edge-24.12.1` and modified patch application to include all `.diff` files.
`packages/apps/kubernetes/Chart.yaml`, `packages/apps/versions_map`	Incremented chart version from `0.15.0` to `0.15.1`; updated version mapping by tying `0.15.0` to a specific commit hash and adding a new entry for `0.15.1`.
`scripts/installer.sh`, `scripts/migrations/8`	Updated installer version from `9` to `10` and corrected migration comment from `Migration 7 --> 9` to `Migration 8 --> 9`.
`scripts/migrations/9`	Added a new migration script that upgrades the Kubernetes appVersion to `0.15.1` and creates/updates the `cozystack-version` ConfigMap to version `10`.

Sequence Diagram(s)

sequenceDiagram
  participant M as Migration Script
  participant K as Kubernetes API
  M->>K: Update kubernetes.apps.cozystack.io (set appVersion to 0.15.1)
  K-->>M: Acknowledgement
  M->>K: Create/Update ConfigMap (cozystack-version = 10)
  K-->>M: Acknowledgement

Possibly related PRs

Revert kamaji edge-24.12.1 #610: The changes in the main PR regarding the Dockerfile update the version of the Kamaji application, while the retrieved PR reverts the version in the same Dockerfile, indicating a direct relationship between the two PRs.
Fix EndpointSlice reconciliation #518: The changes in the main PR regarding the Chart.yaml file version update from 0.15.0 to 0.15.1 are related to the changes in the retrieved PR that also involve a version increment in the Chart.yaml file from 0.14.0 to 0.14.1.
Fix kamaji make update #598: The changes in the main PR, specifically the update to the Dockerfile version, are directly related to the modifications in the retrieved PR, which also updates the Dockerfile version for the Kamaji application.

Suggested labels

size:M, lgtm

Suggested reviewers

kvaps

Poem

Hopping through code in the moonlit night,
I tweak the configs with all my might.
Ports removed and versions soar,
Patches applied and bugs no more.
A bunny cheers for updates that are just right!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b321064 and 392cd86.

📒 Files selected for processing (1)

scripts/migrations/9 (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

scripts/migrations/9

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

kvaps · 2025-02-24T10:42:36Z

packages/apps/kubernetes/templates/cluster.yaml

      extraAnnotations:
        nginx.ingress.kubernetes.io/ssl-passthrough: "true"
-      hostname: {{ .Values.host | default (printf "%s.%s" .Release.Name $host) }}:443
+      hostname: {{ .Values.host | default (printf "%s.%s" .Release.Name $host) }}


Please bump version of Chart.yaml for kubernetes application.

Also, if old clusters will continue using :443 in their configuration they will beblocked, how about adding migration script, to bump all Kubernetes clusters to that version?

kvaps · 2025-02-24T10:43:25Z

packages/system/kamaji/values.yaml

  image:
    pullPolicy: IfNotPresent
-    tag: v0.25.3@sha256:229646a728b58dd0c55dae7abd721ab23e3feecd61f55fa3ad24bb3a614d558f
+    tag: latest@sha256:04aaf9acb6f49e0315295cd0c24655f28b74c6cf628fc6721758842a41d2deef


Please omit these changes, version will be automatically bumped in release cycle

BREAKING: all kuberneteses will be upgraded to chart version 0.15.1

coderabbitai

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a31c3a5 and b321064.

📒 Files selected for processing (5)

packages/apps/kubernetes/Chart.yaml (1 hunks)
packages/apps/versions_map (1 hunks)
scripts/installer.sh (1 hunks)
scripts/migrations/8 (1 hunks)
scripts/migrations/9 (1 hunks)

✅ Files skipped from review due to trivial changes (2)

scripts/migrations/8
packages/apps/kubernetes/Chart.yaml

🔇 Additional comments (2)

scripts/installer.sh (1)

6-6: LGTM: Version increment aligns with new migration script.

The version increment from 9 to 10 corresponds to the new migration script in scripts/migrations/9 that handles the upgrade process.

packages/apps/versions_map (1)

47-48: LGTM: Version mapping updates follow established patterns.

The changes correctly:

Pin kubernetes 0.15.0 to specific commit cb7b815

Add new kubernetes 0.15.1 pointing to HEAD

scripts/migrations/9

Co-authored-by: Andrei Kvapil <kvapss@gmail.com>

kvaps

LGTM

This fix introduced Kamaji update #633 But helm chart didn't actually updated This affected issue with creating new clusters. Ref clastix/kamaji#623 Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

This fix introduced Kamaji update #633 But helm chart didn't actually updated This affected issue with creating new clusters. Ref clastix/kamaji#623 Signed-off-by: Andrei Kvapil <kvapss@gmail.com>  ## Summary by CodeRabbit - **Chores** - Revised application and chart version information alongside updated dependency requirements. - **New Features** - Added new configuration options for tenant control planes, including enhanced network and load balancer settings. - **Documentation** - Updated version indicators and clarified configuration details for default datastore behavior. - **Bug Fixes** - Improved deployment stability by conditionally applying the default datastore setting to avoid potential errors.  Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

Update kamaji version

a31c3a5

* Stripped port number from KamajiControlPlane hostname due to clastix/kamaji#679 * Bumped versions for kamaji and dependent charts

lllamnyp requested a review from kvaps as a code owner February 18, 2025 07:52

dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 18, 2025

dosubot bot added the enhancement New feature or request label Feb 18, 2025

Merge branch 'main' into 119-update-kamaji

77df31e

kvaps reviewed Feb 24, 2025

View reviewed changes

dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 24, 2025

New schema version 10

b321064

BREAKING: all kuberneteses will be upgraded to chart version 0.15.1

lllamnyp force-pushed the 119-update-kamaji branch from 68cb01e to b321064 Compare February 24, 2025 13:33

coderabbitai bot reviewed Feb 24, 2025

View reviewed changes

scripts/migrations/9 Show resolved Hide resolved

scripts/migrations/9 Outdated Show resolved Hide resolved

kvaps reviewed Feb 24, 2025

View reviewed changes

scripts/migrations/9 Outdated Show resolved Hide resolved

Update scripts/migrations/9

392cd86

Co-authored-by: Andrei Kvapil <kvapss@gmail.com>

kvaps approved these changes Feb 25, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 25, 2025

lllamnyp merged commit a6a95b0 into main Feb 25, 2025
2 checks passed

lllamnyp deleted the 119-update-kamaji branch February 25, 2025 08:50

kvaps mentioned this pull request Mar 5, 2025

Fix regression for updating Kamaji #665

Merged

coderabbitai bot mentioned this pull request Dec 1, 2025

[kubernetes] Add version management system with automated version updates #1672

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update kamaji version #633

Update kamaji version #633

Uh oh!

lllamnyp commented Feb 18, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 18, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

kvaps Feb 24, 2025

Uh oh!

kvaps Feb 24, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kvaps left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Update kamaji version #633

Update kamaji version #633

Uh oh!

Conversation

lllamnyp commented Feb 18, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

kvaps Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

kvaps Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kvaps left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lllamnyp commented Feb 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 18, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)