Skip to content

revert-precommit #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kvaps merged 1 commit into from
Nov 15, 2024
Merged

revert-precommit #476

kvaps merged 1 commit into from
Nov 15, 2024
+0 −15

Conversation

@klinch0
Copy link
Contributor

@klinch0 klinch0 commented Nov 15, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Removed unnecessary pre-commit hooks to streamline the development process.
    • Retained the gen-versions-map hook for maintaining version consistency.

@klinch0 klinch0 requested a review from kvaps as a code owner November 15, 2024 06:26
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 15, 2024
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 15, 2024 •
edited
Loading

Walkthrough

The pull request modifies the .pre-commit-config.yaml file by removing multiple repositories and their associated hooks. Specifically, it eliminates the pre-commit-hooks repository along with hooks for end-of-file fixing, trailing whitespace, mixed line endings, and YAML checks. Additionally, the markdownlint-cli repository and its markdown linting hook are removed. The only remaining hook is gen-versions-map, which is defined in a local repository.

Changes

File Change Summary
.pre-commit-config.yaml Removed repositories: pre-commit-hooks (hooks: end-of-file-fixer, trailing-whitespace, mixed-line-ending, check-yaml) and markdownlint-cli (hook: markdownlint). Retained local hook: gen-versions-map.

Possibly related PRs

  • fix exclude for templates #434: The changes in this PR involve modifications to the same hooks (mixed-line-ending and check-yaml) in the .pre-commit-config.yaml file, specifically related to exclusion patterns and arguments, which are directly relevant to the removals in the main PR.

Suggested reviewers

  • kvaps

Poem

In the garden, hooks did play,
But some have gone, they've lost their way.
With versions mapped, we hop along,
A cleaner path, where we belong! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between bfbde07 and 949fd8a.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml (0 hunks)
💤 Files with no reviewable changes (1)
  • .pre-commit-config.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

kvaps
kvaps approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@kvaps kvaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 15, 2024
@kvaps kvaps merged commit 47bd46c into cozystack:main Nov 15, 2024
@kvaps kvaps mentioned this pull request Nov 15, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Dec 2, 2024
Merged
kvaps added a commit that referenced this pull request Jan 12, 2026
@kvaps @claude
[linstor] Update piraeus-server patches with critical fixes
dc2773b 
Update piraeus-server patches to address critical production issues:

- Add fix-duplicate-tcp-ports.diff to prevent duplicate TCP ports
  after toggle-disk operations (upstream PR #476)

- Update skip-adjust-when-device-inaccessible.diff with comprehensive
  fixes for resources stuck in StandAlone after reboot, Unknown state
  race condition, and encrypted LUKS resource deletion (upstream PR #477)

```release-note
[linstor] Fix DRBD resources stuck in StandAlone state after reboot and encrypted resource deletion issues
```

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@kvaps kvaps mentioned this pull request Jan 12, 2026
Merged
kvaps added a commit that referenced this pull request Jan 12, 2026
@kvaps
[linstor] Update piraeus-server patches with critical fixes (#1850)
ea6ec3e 
## What this PR does

This PR updates piraeus-server patches to address several critical
production issues with DRBD resources and LUKS encryption:

1. **Add fix-duplicate-tcp-ports.diff** - Prevents duplicate TCP ports
after toggle-disk operations (upstream PR #476)

2. **Update skip-adjust-when-device-inaccessible.diff** - Comprehensive
fix for multiple issues:
   - Resources stuck in StandAlone state after node reboot
   - Unknown state race condition during satellite restart
   - Encrypted LUKS resource deletion failures
   - Network reconnect blocked by unavailable child device checks

These patches resolve scenarios where DRBD resources fail to
automatically reconnect after node reboots and improve LUKS resource
lifecycle management.

Upstream PRs:
- LINBIT/linstor-server#476
- LINBIT/linstor-server#477

### Release note

```release-note
[linstor] Fix DRBD resources stuck in StandAlone state after reboot and encrypted resource deletion issues
```

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
  * Prevents duplicate TCP port conflicts after disk toggle operations
  * Fixes resources stuck in StandAlone or Unknown state after reboot
  * Resolves issues with encrypted resource deletion
  * Improves handling of temporarily inaccessible storage devices

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
github-actions bot pushed a commit that referenced this pull request Jan 12, 2026
@kvaps @claude @github-actions
[linstor] Update piraeus-server patches with critical fixes
f900db6 
Update piraeus-server patches to address critical production issues:

- Add fix-duplicate-tcp-ports.diff to prevent duplicate TCP ports
  after toggle-disk operations (upstream PR #476)

- Update skip-adjust-when-device-inaccessible.diff with comprehensive
  fixes for resources stuck in StandAlone after reboot, Unknown state
  race condition, and encrypted LUKS resource deletion (upstream PR #477)

```release-note
[linstor] Fix DRBD resources stuck in StandAlone state after reboot and encrypted resource deletion issues
```

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
(cherry picked from commit dc2773b)
github-actions bot pushed a commit that referenced this pull request Jan 12, 2026
@kvaps @claude @github-actions
[linstor] Update piraeus-server patches with critical fixes
274a3a5 
Update piraeus-server patches to address critical production issues:

- Add fix-duplicate-tcp-ports.diff to prevent duplicate TCP ports
  after toggle-disk operations (upstream PR #476)

- Update skip-adjust-when-device-inaccessible.diff with comprehensive
  fixes for resources stuck in StandAlone after reboot, Unknown state
  race condition, and encrypted LUKS resource deletion (upstream PR #477)

```release-note
[linstor] Fix DRBD resources stuck in StandAlone state after reboot and encrypted resource deletion issues
```

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
(cherry picked from commit dc2773b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvaps kvaps kvaps approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@klinch0 @kvaps