chore(dep): use scala-xml 2.x for everything#2548
Merged
Merged
Conversation
This is a continuation or really a revert of what was done in coursier#2274. Originally this was done because Scala 2.12 was on 1.x, but that is no longer the case. You can see the discussion for this in scala/bug#12632. I'm assuming that other things like sbt that will use this will also hit on it as well if it's still on 1.x. See sbt/sbt#6997 for more details on that. This also then bumps Scala 2.12 to 2.12.17 to make sure the scala-xml is aligned there too.
d960edc to
46f2c21
Compare
alexarchambault
approved these changes
Oct 18, 2022
alexarchambault
left a comment
Member
There was a problem hiding this comment.
Thanks @ckipp01! I should merge as soon as the CI is green.
ckipp01
added a commit
to ckipp01/sbt-coursier
that referenced
this pull request
Oct 31, 2022
Same reason that I had for coursier/coursier#2548 but since sbt 1.7.3 was released a bunch of people will see the following: ``` 03:31:06 [info] loading global plugins from /root/.sbt/1.0/plugins 03:31:10 [error] java.lang.RuntimeException: found version conflict(s) in library dependencies; some are suspected to be binary incompatible: 03:31:10 [error] 03:31:10 [error] * org.scala-lang.modules:scala-xml_2.12:2.1.0 (early-semver) is selected over {1.3.0, 1.2.0, 1.0.6} 03:31:10 [error] +- org.scala-lang:scala-compiler:2.12.17 (depends on 2.1.0) 03:31:10 [error] +- org.scala-sbt:testing_2.12:1.7.3 (depends on 1.3.0) 03:31:10 [error] +- org.scala-sbt:sbinary_2.12:0.5.1 (depends on 1.0.6) 03:31:10 [error] +- org.scala-sbt:main_2.12:1.7.3 (depends on 1.3.0) 03:31:10 [error] +- org.scala-sbt:librarymanagement-core_2.12:1.7.1 (depends on 1.2.0) 03:31:10 [error] +- io.get-coursier:lm-coursier-shaded_2.12:2.0.12 (depends on 1.3.0) ``` Since there is a mismatch of scala-xml all over the place. Since Scala has bumped I think it's appropriate the everyone else bumps as well. sbt has also merged in this change for the 1.8.x series.
ckipp01
added a commit
to ckipp01/sbt-coursier
that referenced
this pull request
Oct 31, 2022
Same reason that I had for coursier/coursier#2548 but since sbt 1.7.3 was released a bunch of people will see the following: ``` 03:31:06 [info] loading global plugins from /root/.sbt/1.0/plugins 03:31:10 [error] java.lang.RuntimeException: found version conflict(s) in library dependencies; some are suspected to be binary incompatible: 03:31:10 [error] 03:31:10 [error] * org.scala-lang.modules:scala-xml_2.12:2.1.0 (early-semver) is selected over {1.3.0, 1.2.0, 1.0.6} 03:31:10 [error] +- org.scala-lang:scala-compiler:2.12.17 (depends on 2.1.0) 03:31:10 [error] +- org.scala-sbt:testing_2.12:1.7.3 (depends on 1.3.0) 03:31:10 [error] +- org.scala-sbt:sbinary_2.12:0.5.1 (depends on 1.0.6) 03:31:10 [error] +- org.scala-sbt:main_2.12:1.7.3 (depends on 1.3.0) 03:31:10 [error] +- org.scala-sbt:librarymanagement-core_2.12:1.7.1 (depends on 1.2.0) 03:31:10 [error] +- io.get-coursier:lm-coursier-shaded_2.12:2.0.12 (depends on 1.3.0) ``` Since there is a mismatch of scala-xml all over the place. Since Scala has bumped I think it's appropriate the everyone else bumps as well. sbt has also merged in this change for the 1.8.x series. Relates to sbt/sbt#6997.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation or really a revert of what was done in #2274. Originally this was done because Scala 2.12 was on 1.x, but that is no longer the case. You can see the discussion for this in scala/bug#12632. I'm assuming that other things like sbt that will use this will also hit on it as well if it's still on 1.x. See sbt/sbt#6997 for more details on that. This also then bumps Scala 2.12 to 2.12.17 to make sure the scala-xml is aligned there too.