Skip to content

fix(rust): Enforce that spec.InnerSpec.ChildSize is >= 1#339

Merged
romac merged 2 commits intocosmos:masterfrom
zbuc:childsize_ge_zero
Jul 17, 2024
Merged

fix(rust): Enforce that spec.InnerSpec.ChildSize is >= 1#339
romac merged 2 commits intocosmos:masterfrom
zbuc:childsize_ge_zero

Conversation

@zbuc
Copy link
Contributor

@zbuc zbuc commented Jul 17, 2024

No description provided.

@zbuc zbuc changed the title Enforce that the spec.InnerSpec.ChildSize is >= 1 fix: Enforce that the spec.InnerSpec.ChildSize is >= 1 Jul 17, 2024
@romac romac changed the title fix: Enforce that the spec.InnerSpec.ChildSize is >= 1 fix(rust): Enforce that the spec.InnerSpec.ChildSize is >= 1 Jul 17, 2024
@romac romac requested review from hdevalence and romac July 17, 2024 13:31
@codecov
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.55%. Comparing base (333d554) to head (1e19a16).

Files Patch % Lines
rust/src/verify.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   65.55%   65.55%           
=======================================
  Files           7        7           
  Lines        3606     3609    +3     
=======================================
+ Hits         2364     2366    +2     
- Misses       1242     1243    +1     
Flag Coverage Δ
rust 65.55% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romac romac changed the title fix(rust): Enforce that the spec.InnerSpec.ChildSize is >= 1 fix(rust): Enforce that spec.InnerSpec.ChildSize is >= 1 Jul 17, 2024
Copy link

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romac romac merged commit d124546 into cosmos:master Jul 17, 2024
romac added a commit that referenced this pull request Jul 17, 2024
* Enforce that the spec.InnerSpec.ChildSize is >= 1

* Add changelog entry

---------

Co-authored-by: Romain Ruetschi <romain@informal.systems>
romac added a commit that referenced this pull request Jul 17, 2024
* chore(rust): Bump Rust version to v0.12.0

* chore(rust): Update changelog

* fix(rust): Enforce that `spec.InnerSpec.ChildSize` is >= 1 (#339)

* Enforce that the spec.InnerSpec.ChildSize is >= 1

* Add changelog entry

---------

Co-authored-by: Romain Ruetschi <romain@informal.systems>

* chore(rust): Release v0.11.3 (#340) (#341)

* Bump version to 0.11.3

* Update changelog

---------

Co-authored-by: Chris Czub <chris.czub@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants