prune_test.go (4)

12-12: Add a comment to describe the purpose of the test.

Adding a comment at the beginning of the test function will help other developers understand the purpose of the test.

+ // TestAsyncPruning tests the async pruning functionality of the IAVL tree.
  func TestAsyncPruning(t *testing.T) {

---

13-15: Ensure proper cleanup of the database.

The defer db.Close() statement ensures that the database is closed after the test. However, it's good practice to add a comment explaining the purpose of this statement.

  db, err := dbm.NewGoLevelDB("test", t.TempDir())
  require.NoError(t, err)
+ // Ensure the database is closed after the test.
  defer db.Close()

---

23-39: Consider adding comments to explain the pruning logic.

Adding comments to explain the logic behind the pruning operations will improve the readability and maintainability of the test.

  for i := 0; i < toVersion; i++ {
    for j := 0; j < keyCount; j++ {
      _, err := tree.Set([]byte(fmt.Sprintf("key-%d-%d", i, j)), []byte(fmt.Sprintf("value-%d-%d", i, j)))
      require.NoError(t, err)
    }

    tree.SetCommitting()
    _, v, err := tree.SaveVersion()
    require.NoError(t, err)
    tree.UnsetCommitting()

+   // Prune versions if the current version is a multiple of pruneInterval and greater than keepRecent.
    if v%pruneInterval == 0 && v > keepRecent {
      ti := time.Now()
      require.NoError(t, tree.DeleteVersionsTo(v-keepRecent))
      t.Logf("Pruning %d versions took %v\n", keepRecent, time.Since(ti))
    }
  }

---

58-67: Add comments to explain the reloading logic.

Adding comments to explain the logic behind reloading the tree and checking the available versions will improve the readability and maintainability of the test.

  // Reload the tree
  tree = NewMutableTree(db, 0, false, NewNopLogger())
  _, err = tree.LoadVersion(int64(toVersion) - keepRecent)
  require.Error(t, err)
+ // Check the available versions after reloading the tree.
  versions := tree.AvailableVersions()
  require.Equal(t, versions[0], toVersion-int(keepRecent)+1)
  for _, v := range versions {
    _, err := tree.LoadVersion(int64(v))
    require.NoError(t, err)
  }

tree_test.go (1)

1882-1915: Consider adding comments to improve readability.

Adding comments to explain the purpose of each block of code can improve readability and maintainability.

+	// Test the reference root when pruning
	db = dbm.NewMemDB()
	require.NoError(t, err)
	tree = NewMutableTree(db, 0, false, NewNopLogger())

	_, err = tree.Set([]byte("key1"), []byte("value1"))
	require.NoError(t, err)

	_, _, err = tree.SaveVersion()
	require.NoError(t, err)

	_, _, err = tree.SaveVersion() // empty version
	require.NoError(t, err)

	require.NoError(t, tree.DeleteVersionsTo(1))
	_, _, err = tree.SaveVersion() // empty version
	require.NoError(t, err)

	// Load the tree from disk
	tree = NewMutableTree(db, 0, false, NewNopLogger())
	_, err = tree.Load()
	require.NoError(t, err)

	_, err = tree.Set([]byte("key2"), []byte("value2"))
	require.NoError(t, err)
	_, _, err = tree.SaveVersion()
	require.NoError(t, err)

	// Load the tree from disk to check if the reference root is loaded correctly
	tree = NewMutableTree(db, 0, false, NewNopLogger())
	_, err = tree.Load()
	require.NoError(t, err)
	_, err = tree.Set([]byte("key1"), []byte("value2"))
	require.NoError(t, err)

Configuration used: CodeRabbit UI
Review profile: CHILL