Skip to content

fix: legacy node key#928

Merged
tac0turtle merged 3 commits intorelease/v1.1.xfrom
fix/legacy_nodekey
Apr 8, 2024
Merged

fix: legacy node key#928
tac0turtle merged 3 commits intorelease/v1.1.xfrom
fix/legacy_nodekey

Conversation

@cool-develope
Copy link
Contributor

Context

After reformatting of the pruned root node, it may be referred as a legacy node, since the nonce is 0.

@cool-develope cool-develope requested a review from a team April 5, 2024 17:35
@cool-develope
Copy link
Contributor Author

@Mergifyio backport release/v1.x.x

@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2024

backport release/v1.x.x

✅ Backports have been created

Details

Copy link
Contributor

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it fixes our app hash issue

Copy link
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test case please

_, err = tree.Load()
require.NoError(t, err)
_, err = tree.Set([]byte("key1"), []byte("value2"))
require.NoError(t, err)
Copy link
Contributor Author

@cool-develope cool-develope Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed that the error is triggered here in the original version. cc: @tac0turtle

@tac0turtle
Copy link
Contributor

tests pass locally, git actions are acting weird

@tac0turtle tac0turtle merged commit 0d64869 into release/v1.1.x Apr 8, 2024
@tac0turtle tac0turtle deleted the fix/legacy_nodekey branch April 8, 2024 17:58
mergify bot pushed a commit that referenced this pull request Apr 8, 2024
(cherry picked from commit 0d64869)

# Conflicts:
#	CHANGELOG.md
tac0turtle pushed a commit that referenced this pull request Apr 8, 2024
Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com>
cool-develope added a commit that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants