Skip to content

refactor: remove cosmos-db as a dep (backport #955)#968

Merged
cool-develope merged 4 commits intorelease/v1.2.xfrom
mergify/bp/release/v1.2.x/pr-955
Jul 29, 2024
Merged

refactor: remove cosmos-db as a dep (backport #955)#968
cool-develope merged 4 commits intorelease/v1.2.xfrom
mergify/bp/release/v1.2.x/pr-955

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jul 26, 2024

Summary by CodeRabbit

  • New Features

    • Introduced GoLevelDB implementation for key-value store operations.
    • Added PrefixDB struct for namespacing KVStores.

  • Bug Fixes

    • Enhanced error handling in the Format method of the HexBytes type.

  • Refactor

    • Updated multiple files to use corestore instead of dbm for database operations.
    • Simplified database initialization and setup across various test files.
    • Replaced db.Batch with store.Batch in relevant functions and structs.

  • Documentation

    • Updated explanations of IAVL trees, range proofs, and proof generation in Go code.

  • Chores

    • Updated golangci_version in the Makefile to v1.59.1.
    • Adjusted dependencies in go.mod for improved compatibility and performance.
This is an automatic backport of pull request #955 done by [Mergify](https://mergify.com).

@tac0turtle @mergify
refactor: remove cosmos-db as a dep (#955)
94618cd 
(cherry picked from commit e063edd)

# Conflicts:
#	benchmarks/bench_test.go
#	benchmarks/cosmos-exim/main.go
#	cmd/go.mod
#	cmd/go.sum
#	db/README.md
#	diff_test.go
#	docs/proof/proof.md
#	go.mod
#	go.sum
#	immutable_tree.go
#	iterator_test.go
#	mutable_tree.go
#	nodedb.go
#	testutils_test.go
#	tree_test.go
@mergify
Copy link
Contributor Author

mergify bot commented Jul 26, 2024

Cherry-pick of e063edd has failed:

On branch mergify/bp/release/v1.2.x/pr-955
Your branch is up to date with 'origin/release/v1.2.x'.

You are currently cherry-picking commit e063edd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   Makefile
	modified:   basic_test.go
	modified:   batch.go
	modified:   batch_test.go
	deleted:    benchmarks/hash_test.go
	modified:   cmd/iaviewer/README.md
	modified:   cmd/iaviewer/main.go
	new file:   cmd/iaviewer/wrapper.go
	new file:   db/goleveldb.go
	modified:   db/memdb.go
	new file:   db/prefixdb.go
	modified:   db/types.go
	deleted:    db/wrapper.go
	modified:   fast_iterator.go
	modified:   import.go
	modified:   internal/bytes/bytes.go
	modified:   iterator.go
	modified:   migrate_test.go
	modified:   mock/db_mock.go
	modified:   mockgen.sh
	modified:   tree_random_test.go
	modified:   unsaved_fast_iterator.go
	deleted:    with_gcc_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   benchmarks/bench_test.go
	both modified:   benchmarks/cosmos-exim/main.go
	deleted by us:   cmd/go.mod
	deleted by us:   cmd/go.sum
	deleted by us:   db/README.md
	both modified:   diff_test.go
	both modified:   docs/proof/proof.md
	both modified:   go.mod
	both modified:   go.sum
	both modified:   immutable_tree.go
	both modified:   iterator_test.go
	both modified:   mutable_tree.go
	both modified:   nodedb.go
	both modified:   testutils_test.go
	both modified:   tree_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from a team July 26, 2024 14:17
@mergify mergify bot added the conflicts label Jul 26, 2024
@mergify mergify bot mentioned this pull request Jul 26, 2024
Merged
@coderabbitai
Copy link

coderabbitai bot commented Jul 26, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cool-develope cool-develope merged commit 984d49b into release/v1.2.x Jul 29, 2024
@cool-develope cool-develope deleted the mergify/bp/release/v1.2.x/pr-955 branch July 29, 2024 18:42
cool-develope added a commit that referenced this pull request Jul 31, 2024
@cool-develope
Revert "refactor: remove cosmos-db as a dep (backport #955) (#968)"
f07f9d8 
This reverts commit 984d49b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cool-develope cool-develope cool-develope approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

conflicts

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cool-develope @tac0turtle