Skip to content

Remove architecture dependent getter functions#96

Merged
liamsi merged 4 commits intodevelopfrom
jlandrews/int_types
Sep 7, 2018
Merged

Remove architecture dependent getter functions#96
liamsi merged 4 commits intodevelopfrom
jlandrews/int_types

Conversation

@UnitylChaos
Copy link
Contributor

Closes #93

I've checked using this branch as a dependency for the SDK and it passes tests with just minor changes. (SDK currently calls Version64 which in this branch can be accessed as Version)

cc @liamsi

Copy link
Contributor

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jlandrews! LGTM

@liamsi
Copy link
Contributor

liamsi commented Aug 11, 2018

I've merged #92 (thanks again @jlandrews). Please rebase on (or merge in develop) and will merge this too.

@liamsi
Copy link
Contributor

liamsi commented Aug 29, 2018

I've resolved the merge conflicts and would merge into develop.

…int_types

# Conflicts:
#	immutable_tree.go
#	versioned_tree.go
@liamsi liamsi force-pushed the jlandrews/int_types branch from c084b20 to a757062 Compare August 29, 2018 14:57
@liamsi
Copy link
Contributor

liamsi commented Sep 5, 2018

@jlandrews can you add an entry to the Changelog?

@liamsi liamsi merged commit e17d86c into develop Sep 7, 2018
liamsi added a commit that referenced this pull request Sep 8, 2018
See full changelog here:
https://github.com/tendermint/iavl/blob/develop/CHANGELOG.md#0110-september-7-2018

* Update to CircleCI 2.0 (#108)

* Use 8 bytes to store int64 components of database keys  (#107)

* Introduce KeyFormat that uses a full 8 bytes for int64 values and avoids string manipulatio/scanning

* Add node key and orphan key benchmark

* Fix various issue from PR: punctuation, add overflow test, and improve
scan function

* Remove architecture dependent getter functions (#96)

* Remove architecture dependent getter functions

* update changelog

* Prep Release 0.11.0 (#111)

* Bump version and update change-log
danil-lashin pushed a commit to danil-lashin/iavl that referenced this pull request Oct 24, 2018
* 'develop' of github.com:danil-lashin/iavl:
  Prep Release 0.11.0 (cosmos#111)
  Remove architecture dependent getter functions (cosmos#96)
  Use 8 bytes to store int64 components of database keys  (cosmos#107)
  Update to CircleCI 2.0 (cosmos#108)
  Release 0.10.0: Update Changelog and bump version (cosmos#99)
  delete empty file (relict from merging master into develop)
  Mutable/Immutable refactor and GetImmutable snapshots (cosmos#92)
  Remove unreachable code
  Remove unused variable
  dep: Change tendermint dep to be ^v0.22.0 (cosmos#91)
  Fix benchmark scripts for current code (cosmos#89)
  release v0.9.2 (cosmos#82)
  Various lints (cosmos#80)
  Jae/rangeprooffix (cosmos#75)
ridenaio pushed a commit to idena-network/iavl that referenced this pull request Jul 1, 2019
* Remove architecture dependent getter functions

* update changelog
ridenaio pushed a commit to idena-network/iavl that referenced this pull request Jul 1, 2019
See full changelog here:
https://github.com/tendermint/iavl/blob/develop/CHANGELOG.md#0110-september-7-2018

* Update to CircleCI 2.0 (cosmos#108)

* Use 8 bytes to store int64 components of database keys  (cosmos#107)

* Introduce KeyFormat that uses a full 8 bytes for int64 values and avoids string manipulatio/scanning

* Add node key and orphan key benchmark

* Fix various issue from PR: punctuation, add overflow test, and improve
scan function

* Remove architecture dependent getter functions (cosmos#96)

* Remove architecture dependent getter functions

* update changelog

* Prep Release 0.11.0 (cosmos#111)

* Bump version and update change-log
@tac0turtle tac0turtle deleted the jlandrews/int_types branch July 11, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants